Move appini_header.py invocation to moz.build

RESOLVED FIXED in Firefox 49

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: mshal, Assigned: mshal)

Tracking

(Blocks 1 bug)

unspecified
mozilla49
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(3 attachments)

We can use GENERATED_FILES.script to run it, but there are some slight complications. First, this script depends on a generated file (dist/bin/application.ini), which currently means that it will run in the misc tier. So, I've changed the misc vs. export tier logic for generated files to instead go based on file extension.

Second, even though the application.ini rule generated by moz.build specifies the 'misc' tier, make actually builds it during export since it is a dependency of application.ini.h. In order for that to continue to work when moving the application.ini.h script to moz.build, we have to make sure the paths match.
Some generated files will depend on other generated files, but still
need to be in the export tier because they are C++ headers.

Review commit: https://reviewboard.mozilla.org/r/50187/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50187/
Attachment #8748245 - Flags: review?(mh+mozilla)
Attachment #8748246 - Flags: review?(mh+mozilla)
Attachment #8748247 - Flags: review?(mh+mozilla)
We use _pretty_path when specifying the targets of generated files, so
we need to use _pretty_path for the inputs as well. Otherwise make won't
know that they refer to the same file, and result in "No rule to make
target" errors.

Review commit: https://reviewboard.mozilla.org/r/50189/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50189/
Comment on attachment 8748245 [details]
MozReview Request: Bug 1269787 - Choose tier for GENERATED_FILES based on extension; r?glandium

https://reviewboard.mozilla.org/r/50187/#review47455

meh
Attachment #8748245 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8748246 [details]
MozReview Request: Bug 1269787 - Use _pretty_path instead of full path for inputs; r?glandium

https://reviewboard.mozilla.org/r/50189/#review47457

::: layout/style/test/gen-css-properties.py:12
(Diff revision 1)
> -    data = subprocess.check_output([exe])
> +    run_exe = exe if os.path.isabs(exe) else './%s' % exe
> +    data = subprocess.check_output([run_exe])

You should probably add a comment why this is needed.
Attachment #8748246 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8748247 [details]
MozReview Request: Bug 1269787 - Move appini_header.py rule to moz.build; r?glandium

https://reviewboard.mozilla.org/r/50191/#review47459
Attachment #8748247 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #5)
> Comment on attachment 8748246 [details]
> MozReview Request: Bug 1269787 - Use _pretty_path instead of full path for
> inputs; r?glandium
> 
> https://reviewboard.mozilla.org/r/50189/#review47457
> 
> ::: layout/style/test/gen-css-properties.py:12
> (Diff revision 1)
> > -    data = subprocess.check_output([exe])
> > +    run_exe = exe if os.path.isabs(exe) else './%s' % exe
> > +    data = subprocess.check_output([run_exe])
> 
> You should probably add a comment why this is needed.

Done.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.