1269797 - nestegg: webm triggers high memory usage

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Tyson Smith [:tsmith] (Back Aug 12)]

Attachment: high_mem_test_case.webm

I found this while fuzzing nestegg commit 046e10f7607f943e5889c05fd6c7ab8bc2c614a3

Run the attached test case to trigger the high memory usage.

This test case seems to make the application continue to consume memory until the system low memory killer terminates the process. I'm not sure if this is a bug or if this is the intended functionality but I thought I'd log it since it slows down fuzzing efforts.

Comment 1

[Matthew Gregan [:kinetik]]

I haven't investigated this one yet, but I'll see what I can do to improve it to make fuzzing quicker/easier.

Comment 2

[Matthew Gregan [:kinetik]]

This is a regression caused by https://github.com/kinetiknz/nestegg/commit/370ab4ad10614d68ccf0af5ae123b2661dafa011 (adding nestegg_save_state/nestegg_restore_state).  It continually seeks back to offsets 23, 27, 281, 343 forever, allocation space for the elements as it (re)reads them.

This code was reverted in https://github.com/kinetiknz/nestegg/commit/d25054f16889f38f184ca50d143eb5b67db55b30 and ne_parse returns an error very quickly when parsing this file.

nestegg was updated to a revision after d25054f1 in bug 1261900, so I'll mark this as fixed.