Closed Bug 1269817 Opened 6 years ago Closed 6 years ago
Signature change for crashes with ipc
* If the annotation "ipc_channel_error" is present: ** If the crash contains additional_minidumps=browser, the crash report signature shall be "IPCError-browser | " + ipc_channel_error[:100] ** Otherwise, the crash report signature shall be "IPCError-content | " + ipc_channel_error[:100]
44 bytes, text/x-github-pull-request
|Details | Review|
Content processes which are intentionally killed by the chrome process because of a processing error should have a signature which is distinct from a normal crash. Examples of crashes that this may affect: https://crash-stats.mozilla.com/report/index/b1445175-efbb-4e2d-b321-a85742160429 https://crash-stats.mozilla.com/report/index/c778e6b0-c397-4358-ab94-6dd0d2160429 There are currently unlikely to be any IPCError-content examples because of a bug in the client.
We'd like to reprocess the affected set of crashes from 47beta after this change is made.
Adrian, does the description and User Story make enough sense for you to take on this bug? Benjamin, we are working on a feature whereby you can make a SuperSearch and pipe the results into reprocessing. It's not ready for many days (or weeks if it turns out to be complications). I'm guessing that's too long a wait? If it is, with your guidance I can manually make sure those matching crash IDs are reprocessed. Perhaps we make a dependent bug on this just about the reprocessing.
Assignee: nobody → adrian
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/294847a579f1e69d26eb5a1627458c0c52e2d35a Fixes bug 1269817 - Added a rule for signature if crash contains an IPC channel error. (#3323) r=peterbe
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Here's an example on stage: https://crash-stats.allizom.org/report/index/4acb6f5a-7f95-47ec-8d79-d3a992160427
That looks correct.
(In reply to Benjamin Smedberg [:bsmedberg] from comment #6) > That looks correct. Do you want to file a new bug about the reprocessing? By the way, we have a simple tool now to reprocess individual crashes. You need to be a superuser but at least it's doable. We're actively working on improving that so it can allow for batch-reprocessing without superuser access needed.
I think we should exclude 'IPCError-browser | HangMonitor' from this, it's going to be a grab bag of crash signatures related to plugin hangs. https://crash-stats.mozilla.com/signature/?product=Firefox&dom_ipc_enabled=!__null__&signature=IPCError-browser+%7C+HangMonitor&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&page=1#summary
Jim, could you file that separately and cc me? I'd like to know how you think we should classify those crashes, since my impression is that the stacks are still pretty broken.
You need to log in before you can comment on or make changes to this bug.