when clicking on a mozilla-beta alert, auto load the mozilla-aurora data as well

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jmaher, Assigned: ShrutiJ)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
for mozilla-aurora and mozilla-beta alerts we automatically load mozilla-central/mozilla-inbound/fx-team data.  for beta, I would like aurora data to be loaded as well.
Here's an easier one for you to look at. :) The code in question is here:

https://github.com/mozilla/treeherder/blob/master/ui/js/values.js#L270
https://github.com/mozilla/treeherder/blob/master/ui/js/models/perf/alerts.js#L28

You can see an example of a beta alert here:

https://treeherder.mozilla.org/perf.html#/alerts?id=1551

And an aurora alert here:

https://treeherder.mozilla.org/perf.html#/alerts?id=1583

I would probably just put in a special case to check if the branch is mozilla-aurora or mozilla-beta, and add the other series for those branches if applicable.
Assignee: nobody → shrutijasoria1996
Created attachment 8775038 [details] [review]
[treeherder] SJasoria:Bug_1269825 > mozilla:master
(Assignee)

Comment 3

2 years ago
Comment on attachment 8775038 [details] [review]
[treeherder] SJasoria:Bug_1269825 > mozilla:master

I have made a few changes. They worked well locally.
Attachment #8775038 - Flags: review?(wlachance)
Comment on attachment 8775038 [details] [review]
[treeherder] SJasoria:Bug_1269825 > mozilla:master

Could you make a tweak to the spacing? There's probably an eslint rule we need to enable to catch that case. :)
Attachment #8775038 - Flags: review?(wlachance) → review-
(Assignee)

Comment 5

2 years ago
Comment on attachment 8775038 [details] [review]
[treeherder] SJasoria:Bug_1269825 > mozilla:master

I have added a space. I hope its good now :)
Attachment #8775038 - Flags: review- → review?(wlachance)

Comment 6

2 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/71c02dbb26cb60beee94bac433086bc540c9d6d4
Bug 1269825 - Auto load mozilla-aurora data for mozilla-beta alerts (#1737)
Comment on attachment 8775038 [details] [review]
[treeherder] SJasoria:Bug_1269825 > mozilla:master

Looks good now, thanks!
Attachment #8775038 - Flags: review?(wlachance) → review+
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.