1269825 - when clicking on a mozilla-beta alert, auto load the mozilla-aurora data as well

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

for mozilla-aurora and mozilla-beta alerts we automatically load mozilla-central/mozilla-inbound/fx-team data.  for beta, I would like aurora data to be loaded as well.

Comment 1

[William Lachance (:wlach)]

Here's an easier one for you to look at. :) The code in question is here:

https://github.com/mozilla/treeherder/blob/master/ui/js/values.js#L270
https://github.com/mozilla/treeherder/blob/master/ui/js/models/perf/alerts.js#L28

You can see an example of a beta alert here:

https://treeherder.mozilla.org/perf.html#/alerts?id=1551

And an aurora alert here:

https://treeherder.mozilla.org/perf.html#/alerts?id=1583

I would probably just put in a special case to check if the branch is mozilla-aurora or mozilla-beta, and add the other series for those branches if applicable.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] SJasoria:Bug_1269825 > mozilla:master

Comment 3

[Shruti Jasoria [:ShrutiJ]]

Comment on attachment 8775038 [details] [review]
[treeherder] SJasoria:Bug_1269825 > mozilla:master

I have made a few changes. They worked well locally.

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8775038 [details] [review]
[treeherder] SJasoria:Bug_1269825 > mozilla:master

Could you make a tweak to the spacing? There's probably an eslint rule we need to enable to catch that case. :)

Comment 5

[Shruti Jasoria [:ShrutiJ]]

Comment on attachment 8775038 [details] [review]
[treeherder] SJasoria:Bug_1269825 > mozilla:master

I have added a space. I hope its good now :)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/71c02dbb26cb60beee94bac433086bc540c9d6d4
Bug 1269825 - Auto load mozilla-aurora data for mozilla-beta alerts (#1737)

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8775038 [details] [review]
[treeherder] SJasoria:Bug_1269825 > mozilla:master

Looks good now, thanks!