1269845 - More test cases for background-clip:text

Status: RESOLVED WONTFIX

(Core :: CSS Parsing and Computation, defect)

Description

[u459114]

Base on bug 1265715 comment 55, more test cases need for background-clip:text.

Comment 1

[u459114]

Also need test case of background-color

Comment 2

[u459114]

selection text color test case

Comment 3

[u459114]

Attachment: MozReview Request: bug 1269845 - bg-color and draw-region reftests;

Review commit: https://reviewboard.mozilla.org/r/50751/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50751/

Comment 4

[u459114]

Attachment: MozReview Request: bug 1269845 - text selection reftest;

Review commit: https://reviewboard.mozilla.org/r/50753/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50753/

Comment 5

[u459114]

Comment on attachment 8749109 [details]
MozReview Request: bug 1269845 - bg-color and draw-region reftests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50751/diff/1-2/

Comment 6

[u459114]

Comment on attachment 8749110 [details]
MozReview Request: bug 1269845 - text selection reftest;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50753/diff/1-2/

Comment 7

[u459114]

Comment on attachment 8749109 [details]
MozReview Request: bug 1269845 - bg-color and draw-region reftests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50751/diff/2-3/

Comment 8

[u459114]

Comment on attachment 8749110 [details]
MozReview Request: bug 1269845 - text selection reftest;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50753/diff/2-3/

Comment 9

[Jonathan Kew [:jfkthame]]

Comment on attachment 8749110 [details]
MozReview Request: bug 1269845 - text selection reftest;

https://reviewboard.mozilla.org/r/50753/#review48045

The 'selection' test background-clip-text-2.html fails on both Linux and Windows, because on those platforms selected text is "inverted" to white by default.

I'm not sure offhand whether there's any clear spec for how platform-dependent selection highlighting should interoperate with background-clip:text. I suppose given that background-clip:text is in effect a complete replacement for the usual fill color, there's no sensible way to do Linux/Windows-style "inverted" selection rendering, and so the behavior we've got, of painting the selection highlight behind the text but leaving the text itself (i.e. the clipped bg) unchanged is reasonable -- but that means the reference case here won't work, as it's dependent on platform highlighting behavior.

::: layout/reftests/backgrounds/background-clip-text-1a.html:10
(Diff revision 3)
> -        background-image: linear-gradient(green, green);
> -        background-clip: text;
> +        background: linear-gradient(green, green) repeat scroll 0% 0% padding-box text, none repeat padding-box ;
> +
> +/*url("http://webkit.org/images/green-background.png") repeat scroll 0% 0% padding-box text, rgb(152, 90, 11) none repeat scroll 0% 0% padding-box content-box*/

This change doesn't seem like it belongs in this patch?

Comment 10

[Jonathan Kew [:jfkthame]]

Comment on attachment 8749109 [details]
MozReview Request: bug 1269845 - bg-color and draw-region reftests;

https://reviewboard.mozilla.org/r/50751/#review48059

These tests look OK, but I notice there's quite a lot of antialiasing-fuzz on background-clip-text-1g in the try run. Given the upcoming implementation change in bug 1269971, which seems to have a big effect on antialiasing (and I'd like us to try and improve it), maybe it's better to wait for that to settle down before trying to land these.