NULL pc in frame passed to debugger hook

VERIFIED INVALID

Status

()

Core
JavaScript Engine
VERIFIED INVALID
16 years ago
16 years ago

People

(Reporter: Robert Ginda, Assigned: Robert Ginda)

Tracking

Trunk
mozilla1.0
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
As we're about to call into a function or start executing a script, the debugger
hook is called with a frame containing a NULL pc.  If that pc were instead
initialized to the start of the script we were about to execute life would be
easier for the debugger.
(Assignee)

Comment 1

16 years ago
Brendan, I vaguely recall you were going to test for a null pc as a fix for some
other debugger bug, I don't remember if that's the fix that went in, do you?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 2

16 years ago
Created attachment 70706 [details] [diff] [review]
patch
(Assignee)

Comment 3

16 years ago
oops, meant to assigne this to myself.
Assignee: rogerl → rginda
Status: ASSIGNED → NEW
Comment on attachment 70706 [details] [diff] [review]
patch

Seems reasonable. r=shaver.
Attachment #70706 - Flags: review+
Comment on attachment 70706 [details] [diff] [review]
patch

The debugger can figure out this state and cope.  We do not want to spend
cycles here when the interpreter will get around to setting pc (if script), and
at one point the GC needed to know that we were not yet interpreting.  I don't
think this is a good change for the core engine.  Make the debugger pay the ?:
or other random-logic cost.

/be
Attachment #70706 - Flags: needs-work+
(Assignee)

Comment 6

16 years ago
invalid
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → INVALID

Comment 7

16 years ago
Marking Verified -
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.