1269888 - Update color for pressed "Hidden devices" state

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Hidden devices pressed color should match the pressed state for the other items.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1269888 - Update color for pressed "Hidden devices" state.

Review commit: https://reviewboard.mozilla.org/r/50289/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50289/

Comment 2

[Chenxia Liu [:liuche]]

Sebastian, I'm running into some problems here, and I can't figure out why setting the selector isn't having any effect. I think my understanding of how this works isn't correct, so I thought I'd ask you.

I'm trying to change the pressed state color of the "Hidden devices" item to match that of the other home panel list items. So I switched to setting the android:listSelector instead of android:background, which is what the other home panel lists do, but at that point, no selection happens at all. I've also tried setting the style on the RecyclerView itself, but again, nothing happens when pressing on the item.

Is setting the background for the RecyclerView somehow different from using the listSelector, and also uses some different colors for some reason? I feel like this should be really straightforward :/

Comment 3

[Chenxia Liu [:liuche]]

Ah, I see what's going on - we're not using a different color for these highlights, but the highlight is partially transparent and so the color looks different on different items. Bug 1066751 discusses unifying these colors.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.