Handle visible frame sets more generically in PresShell

REOPENED
Assigned to

Status

()

defect
REOPENED
3 years ago
3 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

(Blocks 1 bug)

unspecified
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

As we add more notions of frame visibility it becomes more important that the frame visibility-related code handles the different visibility counters generically whenever possible. This minimizes the amount of code we have to update when a new visibility counter is introduced. Let's get this done before things get complicated further.
Here's the patch. All this does is try to use VisibilityCounters where possible
instead of hardcoding specific types of frame visibility.
Attachment #8748431 - Flags: review?(mstange)
Attachment #8748431 - Flags: review?(mstange) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4517cddd204ee56e5ef8ca9dbd7aed6efe911895
Bug 1269934 - Handle visible frame sets more generically in PresShell. r=mstange
https://hg.mozilla.org/mozilla-central/rev/4517cddd204e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1272357
No longer depends on: 1272357
I backed this bug out on inbound, I expect the backout to get merged to mozilla-central. I plan to also request uplift to backout on aurora (so this bug would not be landed in any version of Firefox).

Bug 1284350 tracks the back out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
You need to log in before you can comment on or make changes to this bug.