Replace PresShell::DecVisibleCount() with a general map function

REOPENED
Assigned to

Status

()

REOPENED
3 years ago
3 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
PresShell::DecVisibleCount() just iterates over all the frames in a visible frames set and decrements a counter for each one for which visibility tracking is still enabled. We'll soon need to add more code that does this kind of iteration, so it makes sense to replace DecVisibleCount() with a general iterator function that takes a lambda as an argument.
(Assignee)

Comment 1

3 years ago
Created attachment 8748433 [details] [diff] [review]
Replace PresShell::DecVisibleCount() with a general map function.

Here's the patch. We'll be making use of this map function a good deal in
upcoming patches.
Attachment #8748433 - Flags: review?(mstange)
(Assignee)

Updated

3 years ago
Blocks: 1269937
Attachment #8748433 - Flags: review?(mstange) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/45c3308d49c95e37c8d1e4855231baa976a7fe9a
Bug 1269935 - Replace PresShell::DecVisibleCount() with a general map function. r=mstange

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/45c3308d49c9
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1272357
(Assignee)

Updated

3 years ago
No longer depends on: 1272357
I backed this bug out on inbound, I expect the backout to get merged to mozilla-central. I plan to also request uplift to backout on aurora (so this bug would not be landed in any version of Firefox).

Bug 1284350 tracks the back out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
You need to log in before you can comment on or make changes to this bug.