Open
Bug 1269938
Opened 8 years ago
Updated 1 year ago
Cert error debug information clips error page content when advanced panel text is long
Categories
(Firefox :: General, defect, P3)
Firefox
General
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox49 | --- | affected |
People
(Reporter: nhnt11, Unassigned)
References
Details
(Whiteboard: [fxprivacy])
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
Details |
Cert error debug information is currently positioned using |top: 100%|, so when the page content already overflows the viewport, the debug info panel will overlap the bottom of the page content.
Reporter | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50285/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50285/
Attachment #8748439 -
Flags: review?(gijskruitbosch+bugs)
Comment 2•8 years ago
|
||
Comment on attachment 8748439 [details] MozReview Request: Bug 1269938 - Position cert error debug information using the body's scrollHeight. r=Gijs https://reviewboard.mozilla.org/r/50285/#review47189 Now it still breaks if you resize the viewport after the panel has been displayed, though. Can't this just live inside the absolutely-positioned container you added to make the 'advanced' panel behave, and be at the bottom in that? Or does that not work because of the width of the thing?
Attachment #8748439 -
Flags: review?(gijskruitbosch+bugs)
Updated•8 years ago
|
Flags: qe-verify?
Priority: -- → P3
Reporter | ||
Comment 3•8 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #2) > Comment on attachment 8748439 [details] > MozReview Request: Bug 1269938 - Position cert error debug information using > the body's scrollHeight. r=Gijs > > https://reviewboard.mozilla.org/r/50285/#review47189 > > Now it still breaks if you resize the viewport after the panel has been > displayed, though. > > Can't this just live inside the absolutely-positioned container you added to > make the 'advanced' panel behave, and be at the bottom in that? Or does that > not work because of the width of the thing? Yeah, I couldn't get it to fill the viewport when I put it in the absolutely-positioned container. One possible compromise is to get rid of the background and top border, that way it looks alright and is positioned correctly. Another problem is that the contents of the certificate chain don't wrap (because each line is treated as a full word), resulting in scrollbars. Setting |word-break: break-all| fixes that but causes the english text right above the cert chain to break at chars instead of words too. I need to figure out the best way to add a class to the cert text so that I can make it wrap, I'll have another go at it later.
Comment 4•8 years ago
|
||
(In reply to Nihanth Subramanya [:nhnt11] from comment #3) > Another problem is that the contents of the certificate chain don't wrap > (because each line is treated as a full word), resulting in scrollbars. > Setting |word-break: break-all| fixes that but causes the english text right > above the cert chain to break at chars instead of words too. > > I need to figure out the best way to add a class to the cert text so that I > can make it wrap, I'll have another go at it later. Would it actually be OK to wrap the cert text? I don't know how picky different tools are, but inserting newlines in that text seems like the kind of thing that could trip things up. But maybe I'm being overly paranoid? Mark, do you know?
Flags: needinfo?(mgoodwin)
Comment 5•8 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #4) > > I need to figure out the best way to add a class to the cert text so that I > > can make it wrap, I'll have another go at it later. > > Would it actually be OK to wrap the cert text? I don't know how picky > different tools are, but inserting newlines in that text seems like the kind > of thing that could trip things up. But maybe I'm being overly paranoid? > Mark, do you know? I'm not greatly concerned - the only cert text I'm seeing in that is SANs and subject information in any case?
Flags: needinfo?(mgoodwin)
Reporter | ||
Comment 6•3 years ago
|
||
I've lost context on this and don't remember what blocked it 5 years ago.
Assignee: nhnt11 → nobody
Status: ASSIGNED → NEW
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•