Closed
Bug 1270011
Opened 8 years ago
Closed 8 years ago
Session store logging breaks clearing session history on exit when not restoring tabs
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox46 unaffected, firefox47 unaffected, firefox48+ fixed, firefox49+ fixed, fennec48+)
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox46 | --- | unaffected |
firefox47 | --- | unaffected |
firefox48 | + | fixed |
firefox49 | + | fixed |
fennec | 48+ | --- |
People
(Reporter: JanH, Assigned: JanH)
References
Details
(Keywords: regression)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
Margaret
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
There is no window in the normalData when clearing browsing history on quit with tab restore set to "never restore", which breaks the assumption made in the logging function. It also means that in that case, the current session will show up as "Tabs from last time" on next startup despite wanting to clear the history on exit. Review commit: https://reviewboard.mozilla.org/r/50341/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50341/
Attachment #8748518 -
Flags: review?(margaret.leibovic)
Comment 2•8 years ago
|
||
Comment on attachment 8748518 [details] MozReview Request: Bug 1270011 - Check normalData.windows[0] exists before accessing tab count. r=margaret https://reviewboard.mozilla.org/r/50341/#review47241 Doh, good catch! A lesson that something as simple as adding logging statements always has risks.
Attachment #8748518 -
Flags: review?(margaret.leibovic) → review+
Updated•8 years ago
|
tracking-fennec: --- → 48+
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=829bbe3917a2
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8748518 [details] MozReview Request: Bug 1270011 - Check normalData.windows[0] exists before accessing tab count. r=margaret Approval Request Comment [Feature/regressing bug #]: bug 1264717 [User impact if declined]: When not restoring tabs and clearing history on exit, the current browsing session won't be cleared, but show up as "Tabs from last time" instead. [Describe test coverage new/current, TreeHerder]: manual [Risks and why]: Low, only adds a missing null-check before accessing a property. [String/UUID change made/needed]: none
Attachment #8748518 -
Flags: approval-mozilla-aurora?
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9ccf0528e3c1
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9ccf0528e3c1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 7•8 years ago
|
||
Tracking for 48/49, recent regression
tracking-firefox48:
--- → +
tracking-firefox49:
--- → +
Comment 8•8 years ago
|
||
Comment on attachment 8748518 [details] MozReview Request: Bug 1270011 - Check normalData.windows[0] exists before accessing tab count. r=margaret Fix for clearing saved tabs, please uplift to aurora.
Attachment #8748518 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/2c40e21dafaa
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•