Closed Bug 1270069 Opened 4 years ago Closed 4 years ago

Do not use DebugOnly in ElementAdder

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: nox, Assigned: nox)

Details

Attachments

(1 file, 1 obsolete file)

DebugOnly is a pain to bind in other languages (e.g. Rust), let's use `ifdef DEBUG` instead.
Attachment #8748598 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8748598 [details] [diff] [review]
0001-Do-not-use-DebugOnly-in-ElementAdder.patch

Review of attachment 8748598 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/public/Class.h
@@ +468,5 @@
> +      :
> +#ifdef DEBUG
> +        length_(length),
> +#endif
> +        resObj_(cx), vp_(vp), index_(0), getBehavior_(behavior)

C++ will raise a warning if the fields are not initialized in the same order as they are declared in the body of the class.
Attachment #8748598 - Flags: review?(nicolas.b.pierron)
Addressed nbp's remark.
Attachment #8748598 - Attachment is obsolete: true
Attachment #8748697 - Flags: review?(nicolas.b.pierron)
Attachment #8748697 - Flags: review?(nicolas.b.pierron) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8ee9e784d79f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.