Closed Bug 1270119 Opened 6 years ago Closed 6 years ago

Update browser_localStorage_privatestorageevent.js to run on e10s

Categories

(Core :: DOM: Content Processes, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
e10s + ---
firefox49 --- fixed

People

(Reporter: nika, Assigned: nika)

References

(Blocks 1 open bug)

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

No description provided.
Whiteboard: btpp-active
Comment on attachment 8748652 [details] [diff] [review]
Rewrite browser_localStorage_privatestoragevent.js to run on e10s

Review of attachment 8748652 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/browser/browser_localStorage_privatestorageevent.js
@@ +19,4 @@
>  
> +  var privTab = privWin.gBrowser.addTab(URL);
> +  yield BrowserTestUtils.browserLoaded(privWin.gBrowser.getBrowserForTab(privTab));
> +  var privBrowser = gBrowser.getBrowserForTab(privTab);

I find this suspect; why isn't this using privWin?

@@ +22,5 @@
> +  var privBrowser = gBrowser.getBrowserForTab(privTab);
> +
> +  var pubTab = pubWin.gBrowser.addTab(URL);
> +  yield BrowserTestUtils.browserLoaded(pubWin.gBrowser.getBrowserForTab(pubTab));
> +  var pubBrowser = gBrowser.getBrowserForTab(pubTab);

I find this suspect; why isn't this using pubWin?
Attachment #8748652 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/3fa8799f00e7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.