Closed
Bug 1270119
Opened 9 years ago
Closed 9 years ago
Update browser_localStorage_privatestorageevent.js to run on e10s
Categories
(Core :: DOM: Content Processes, defect)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: nika, Assigned: nika)
References
(Blocks 1 open bug)
Details
(Whiteboard: btpp-active)
Attachments
(1 file)
8.31 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8748652 -
Flags: review?(josh)
Updated•9 years ago
|
Whiteboard: btpp-active
tracking-e10s:
--- → ?
Updated•9 years ago
|
Blocks: e10s-tests
Comment 2•9 years ago
|
||
Comment on attachment 8748652 [details] [diff] [review]
Rewrite browser_localStorage_privatestoragevent.js to run on e10s
Review of attachment 8748652 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/tests/browser/browser_localStorage_privatestorageevent.js
@@ +19,4 @@
>
> + var privTab = privWin.gBrowser.addTab(URL);
> + yield BrowserTestUtils.browserLoaded(privWin.gBrowser.getBrowserForTab(privTab));
> + var privBrowser = gBrowser.getBrowserForTab(privTab);
I find this suspect; why isn't this using privWin?
@@ +22,5 @@
> + var privBrowser = gBrowser.getBrowserForTab(privTab);
> +
> + var pubTab = pubWin.gBrowser.addTab(URL);
> + yield BrowserTestUtils.browserLoaded(pubWin.gBrowser.getBrowserForTab(pubTab));
> + var pubBrowser = gBrowser.getBrowserForTab(pubTab);
I find this suspect; why isn't this using pubWin?
Attachment #8748652 -
Flags: review?(josh) → review+
Comment 4•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•