1270145 - InputQueue's touch counter doesn't track touches from canceled events

Status: RESOLVED INVALID

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

In bug 1231570 I added a test that synthesized a long-press and called preventDefault on the resulting contextmenu event. Turns out this leaves the input queue's mTouchCounter with an incorrect count, because it counts the touchstart but not the touchend. The input block injected for the long-press is cancelled and the touchend is dropped, so it never goes through TouchBlockState::DispatchEvent, which is what updates the touch counter. We should update that counter even for cancelled events.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Actually this is wrong. The mTouchCounter in InputQueue is meant to track the number of active touches that an APZC is tracking, and so dropped events should not be included there. The code is fine, and the error I was seeing in my test has to be fixed elsewhere.