1270173 - Move protocol.js from devtools/server to devtools/shared.

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Eddy Bruel [:ejpbruel]]

To decouple the fronts from their actors, we also need remove all their dependencies on server code. Unfortunately, one such dependency is protocol.js itself. Since protocol.js is used by both the fronts and the actors, it should be moved to shared directory.

Comment 1

[Jen Fong-Adwent [:ednapiranha]]

Attachment: Bug1270173.patch

A really large patch but it's pretty straightforward. Not sure if I missed anything else in this fix, but let me know if this is correct.

Comment 2

[Jen Fong-Adwent [:ednapiranha]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eeeed7ad5475&selectedJob=20371296

Comment 3

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8749184 [details] [diff] [review]
Bug1270173.patch

Review of attachment 8749184 [details] [diff] [review]:
-----------------------------------------------------------------

Not much to review here. The important question is whether you forgot to update any requires. The best way to figure that out would be to simply run the tests.

If you can get a green try run for the patch, it looks good to land to me.

Comment 4

[Jen Fong-Adwent [:ednapiranha]]

Attachment: Bug1270173.patch

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7672195fb959

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a3d59df2a8e3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a3d59df2a8e3