1270198 - Clean up unused Reader View code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect, P5)

Description

[Andrzej Hunt :ahunt]

As suggested by margaret in Bug 1265004:
> This got me looking into this code more closely, and there's some unused
> stuff in here that we can clean up, like this unused
> "Reader:FetchContent" method and its corresponding logic.

Splitting this into a separate bug since we'll want to uplift Bug 1265004, whereas there's no rush to land this.

Comment 1

[Andrzej Hunt :ahunt]

Attachment: MozReview Request: Bug 1270198 - Remove unused Reader:FetchContent and associated logic r?margaret

Review commit: https://reviewboard.mozilla.org/r/50513/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50513/

Comment 2

[:Margaret Leibovic]

Comment on attachment 8748752 [details]
MozReview Request: Bug 1270198 - Remove unused Reader:FetchContent and associated logic r?margaret

https://reviewboard.mozilla.org/r/50513/#review47313

::: mobile/android/chrome/content/Reader.js:216
(Diff revision 1)
> -        status: this.STATUS_FETCH_FAILED_TEMPORARY,
> -      });
> -    });
> -  },
> -
>    _downloadAndCacheArticle: Task.async(function* (url) {

We can also get rid of this method.

Comment 3

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/eacfa3e222b31ad989e8d6689808b4fe1b7e67c7
Bug 1270198 - Remove unused Reader:FetchContent and associated logic r=margaret

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eacfa3e222b3