Closed Bug 1270198 Opened 6 years ago Closed 5 years ago

Clean up unused Reader View code

Categories

(Firefox for Android Graveyard :: Reader View, defect, P5)

defect

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed

People

(Reporter: ahunt, Assigned: ahunt)

Details

Attachments

(1 file)

As suggested by margaret in Bug 1265004:
> This got me looking into this code more closely, and there's some unused
> stuff in here that we can clean up, like this unused
> "Reader:FetchContent" method and its corresponding logic.

Splitting this into a separate bug since we'll want to uplift Bug 1265004, whereas there's no rush to land this.
Assignee: nobody → ahunt
Status: NEW → ASSIGNED
Priority: -- → P5
Comment on attachment 8748752 [details]
MozReview Request: Bug 1270198 - Remove unused Reader:FetchContent and associated logic r?margaret

https://reviewboard.mozilla.org/r/50513/#review47313

::: mobile/android/chrome/content/Reader.js:216
(Diff revision 1)
> -        status: this.STATUS_FETCH_FAILED_TEMPORARY,
> -      });
> -    });
> -  },
> -
>    _downloadAndCacheArticle: Task.async(function* (url) {

We can also get rid of this method.
Attachment #8748752 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/integration/fx-team/rev/eacfa3e222b31ad989e8d6689808b4fe1b7e67c7
Bug 1270198 - Remove unused Reader:FetchContent and associated logic r=margaret
https://hg.mozilla.org/mozilla-central/rev/eacfa3e222b3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.