1270200 - correct button styles on /contribute/signup tasks (not a blocker for launch)

Status: RESOLVED FIXED

Description

[Jennifer Bertsch [:jbertsch]]

Let's use the correct styles for copy on buttons on the /contribute/signup task pages

Holly - could you please explain the correct styles below?

This doesn't block launch in the sprint ending May 11.

Comment 1

[Schalk Neethling [:espressive]]

(In reply to Jennifer Bertsch [:jbertsch] from comment #0)
> Let's use the correct styles for copy on buttons on the /contribute/signup
> task pages
> 
> Holly - could you please explain the correct styles below?
> 
> This doesn't block launch in the sprint ending May 11.

In the Google Doc Troy mentioned that we should consistently use sentence case for the button on /signup - did I misread or, did this change?

Comment 2

[Schalk Neethling [:espressive]]

From the doc: "I think we should make the case of all the button copy consistent — I'm suggesting we use sentence case, but without punctuation."

Comment 3

[Holly Habstritt Gaal [:Habber]]

(In reply to Schalk Neethling [:espressive] from comment #2)
> From the doc: "I think we should make the case of all the button copy
> consistent — I'm suggesting we use sentence case, but without punctuation."

The following task detail pages have all upper casing text in the buttons. Please change to sentence casing:
- https://bedrock-demo-schalk-contribute.us-west.moz.works/en-US/contribute/task/follow-mozilla/
- https://bedrock-demo-schalk-contribute.us-west.moz.works/en-US/contribute/task/encryption/
- https://bedrock-demo-schalk-contribute.us-west.moz.works/en-US/contribute/task/joy-of-coding/
- https://bedrock-demo-schalk-contribute.us-west.moz.works/en-US/contribute/task/devtools-challenger/
- https://bedrock-demo-schalk-contribute.us-west.moz.works/en-US/contribute/task/stumbler/ 

Download link for Dev Edition should be green since it's a product download button. Any product download button that shows up in the conditional states should be green w/ sentence casing.

Comment 4

[Alex Gibson [:agibson]]

> Download link for Dev Edition should be green since it's a product download button.

Just to be double clear here, when I visit this URL:

https://www.mozilla.org/en-US/contribute/task/devtools-challenger/

Clicking the button that says "Download Firefox Developer Edition" takes me to the /firefox/developer page, and does not generate a product download directly.

Is this behavior still correct (even after we change the button color to green), or should this in fact be a "real" download button?

Comment 5

[Alex Gibson [:agibson]]

I'm going to move forward and change "Download Firefox Developer Edition" to be a real download button (green) instead of being a link to the product page. 

Holly, if this is not correct please let me know. Otherwise feel free to clear needsinfo. Thanks!

Comment 6

[Holly Habstritt Gaal [:Habber]]

(In reply to Alex Gibson [:agibson] from comment #5)
> I'm going to move forward and change "Download Firefox Developer Edition" to
> be a real download button (green) instead of being a link to the product
> page. 
> 
> Holly, if this is not correct please let me know. Otherwise feel free to
> clear needsinfo. Thanks!

Works for me!

Comment 7

[Alex Gibson [:agibson]]

Created attachment 8753271 [details] [review]
GitHub pull request

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/3145920bcca3b8cae5c641f89547c5d6397e6101
[fix bug 1270200] Use correct button styles on /contribute/signup tasks