Closed
Bug 1270200
Opened 9 years ago
Closed 9 years ago
correct button styles on /contribute/signup tasks (not a blocker for launch)
Categories
(www.mozilla.org :: Pages & Content, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jbertsch, Assigned: agibson)
References
()
Details
Attachments
(1 file)
Let's use the correct styles for copy on buttons on the /contribute/signup task pages
Holly - could you please explain the correct styles below?
This doesn't block launch in the sprint ending May 11.
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(hhabstritt.bugzilla)
Comment 1•9 years ago
|
||
(In reply to Jennifer Bertsch [:jbertsch] from comment #0)
> Let's use the correct styles for copy on buttons on the /contribute/signup
> task pages
>
> Holly - could you please explain the correct styles below?
>
> This doesn't block launch in the sprint ending May 11.
In the Google Doc Troy mentioned that we should consistently use sentence case for the button on /signup - did I misread or, did this change?
Comment 2•9 years ago
|
||
From the doc: "I think we should make the case of all the button copy consistent — I'm suggesting we use sentence case, but without punctuation."
Comment 3•9 years ago
|
||
(In reply to Schalk Neethling [:espressive] from comment #2)
> From the doc: "I think we should make the case of all the button copy
> consistent — I'm suggesting we use sentence case, but without punctuation."
The following task detail pages have all upper casing text in the buttons. Please change to sentence casing:
- https://bedrock-demo-schalk-contribute.us-west.moz.works/en-US/contribute/task/follow-mozilla/
- https://bedrock-demo-schalk-contribute.us-west.moz.works/en-US/contribute/task/encryption/
- https://bedrock-demo-schalk-contribute.us-west.moz.works/en-US/contribute/task/joy-of-coding/
- https://bedrock-demo-schalk-contribute.us-west.moz.works/en-US/contribute/task/devtools-challenger/
- https://bedrock-demo-schalk-contribute.us-west.moz.works/en-US/contribute/task/stumbler/
Download link for Dev Edition should be green since it's a product download button. Any product download button that shows up in the conditional states should be green w/ sentence casing.
Flags: needinfo?(hhabstritt.bugzilla)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → agibson
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•9 years ago
|
||
> Download link for Dev Edition should be green since it's a product download button.
Just to be double clear here, when I visit this URL:
https://www.mozilla.org/en-US/contribute/task/devtools-challenger/
Clicking the button that says "Download Firefox Developer Edition" takes me to the /firefox/developer page, and does not generate a product download directly.
Is this behavior still correct (even after we change the button color to green), or should this in fact be a "real" download button?
Flags: needinfo?(hhabstritt.bugzilla)
Assignee | ||
Comment 5•9 years ago
|
||
I'm going to move forward and change "Download Firefox Developer Edition" to be a real download button (green) instead of being a link to the product page.
Holly, if this is not correct please let me know. Otherwise feel free to clear needsinfo. Thanks!
Comment 6•9 years ago
|
||
(In reply to Alex Gibson [:agibson] from comment #5)
> I'm going to move forward and change "Download Firefox Developer Edition" to
> be a real download button (green) instead of being a link to the product
> page.
>
> Holly, if this is not correct please let me know. Otherwise feel free to
> clear needsinfo. Thanks!
Works for me!
Flags: needinfo?(hhabstritt.bugzilla)
Assignee | ||
Comment 7•9 years ago
|
||
Comment 8•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/3145920bcca3b8cae5c641f89547c5d6397e6101
[fix bug 1270200] Use correct button styles on /contribute/signup tasks
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•