1270212 - cs_nav_prefs_navigator.xhtml: Mentioned "Only match locations, not website titles" does not exist

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Rainer Bielefeld]

Steps how to reproduce  with  English SeaMonkey 2.45a1  (Windows NT 6.1; WOW64; rv:48.0)  Gecko/20100101 Firefox/48.0 Build 20160308001946  (Default Classic Theme)  on German WIN7 64bit:

1. Browser → F1
   » Help appears
2. Type search string "Browser Preferences" → Click hit 
   "Browser Preferences"
   » Related Help appears
3. In TOC click "Location Bar"
   Bug: under "Autocomplete" a preference 
        "Only match locations, not website titles" is mentioned, but 
         this  does not exist in dialog  ˋEdit → Preferences → Browser → 
         Location barˊ

a) This item did exist in Locatoin Bar Preferences of SM 2.0.0 (and may
   be later), but not in current SM versions.
b) Suggestion for Fix: drop this list item

Comment 1

[Isaac Schemm]

Reproducible on 2.48a1 (comm-central, build 20160802141413)

Comment 2

[Amit singh]

want to work on this bug

Comment 3

[Rainer Bielefeld]

(In reply to Amit singh from comment #2)
> want to work on this bug

Any questions? Did you already skim <http://www.seamonkey-project.org/dev/get-involved>?

Comment 4

[Richa]

can i work on this bug??

Comment 5

[Rainer Bielefeld]

(In reply to Richa from comment #4)
> can i work on this bug??

Yes, of course! I will send some advice to you by Email.

Comment 6

[Richa]

ya please,let me know where do i start from,waiting for your mail.

Comment 7

[Amit singh]

(In reply to Rainer Bielefeld from comment #3)
> (In reply to Amit singh from comment #2)
> > want to work on this bug
> 
> Any questions? Did you already skim
> <http://www.seamonkey-project.org/dev/get-involved>?

I went to get involved page of seamonkey but i encountered broken link in (Fix Bugs > fix it)

Comment 8

[Amit singh]

(In reply to Amit singh from comment #7)
> (In reply to Rainer Bielefeld from comment #3)
> > (In reply to Amit singh from comment #2)
> > > want to work on this bug
> > 
> > Any questions? Did you already skim
> > <http://www.seamonkey-project.org/dev/get-involved>?
> 
> I went to get involved page of seamonkey but i encountered broken link in
> (Fix Bugs > fix it)

>how do i fix the bug

Comment 9

[Rainer Bielefeld]

(In reply to Amit singh from comment #7)
> i encountered broken link 

Thank you for the hint, I submitted "Bug 1308083 - Repair or remove "fix it" hyperlink" for that problem.

As a first step you should try to CONFIRM <https://wiki.mozilla.org/SeaMonkey/QA/Triage_HowTo> the problem.
Did you already find the source for "cs_nav_prefs_navigator.xhtml" on Mercurial?

Comment 10

[Clara Moraes Dantas]

Hi! =)
I'm a new contributor, can I work on this bug?

Comment 11

[Frank-Rainer Grahl (:frg)]

Clara,

sure just attach a patch and we will assign it to you. If you need some information just ask.

FRG

Comment 12

[Rupesh]

hi I am new to mozilla ,I dont know how to contribute to mozilla but wanted to do work for it ,so can I fix this ?? So What is expected to do ??

Comment 13

[Rainer Bielefeld]

(In reply to Rupesh from comment #12)
> wanted to do work for it ,so can I fix this ?? So What is expected to do ??

Hi, as a first step you should try to reproduce this bug on your Computer following "Steps how to reproduce" in original bug report. 

I sent some additional hints in separate email.

Comment 14

[proamg9]

Hi
I would o work on this.  Could you send me a little more info?

Thank you.

Comment 15

[Rainer Bielefeld]

As a first step please try to reproduce the issue on your PC.

Comment 16

[mehulparmariitr]

I think steps to reproduce this bug have changed. Can you update Rainer?

Comment 17

[Frank-Rainer Grahl (:frg)]

Attachment: Capture.PNG

Conditions are still unchanged.

Comment 18

[anushka.j464]

Hi, I would like o fix the bug, and this would be my first bug. Could you please guide me?

Comment 19

[Rainer Bielefeld]

@[e-mail]
Please follow https://wiki.mozilla.org/SeaMonkey/FAQ#How_To_Start_Contributing_Code

Comment 20

[Utkarsh]

Hi I would like to work on this. Can you please guide me

Comment 21

[Daniel Bomar]

Attachment: Bug 1270212 - Remove reference to unused menu item from help documentation

Comment 22

[Daniel Bomar]

Hi, first time contributor here. I found the file and removed the text about the menu item that is no longer there. Looks like the moz-phab script worked as it automatically added my patch to this thread.

I'm not sure how to build SeaMonkey to test though. Documentation here seems to be out of date: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_SeaMonkey_build

As mentioned at the top of this other page, client.py no longer exists: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Getting_comm-central

I was originally looking to contribute to Firefox before I came across this bug that looked simple enough to by my first go at this so I've got Firefox cloned from Mercurial and was able to compile that on my machine but I don't see a comm-central sub-directory in there.

Lastly, it looks like my patch needs a reviewer. I'm not sure if that's a thing that needs to be assigned by me (and if so who am I supposed to assign and where do I do that?)

Comment 23

[Frank-Rainer Grahl (:frg)]

Daniel,
we still use old fashioned mercurial patches only. Your patch looks good.
Because of all the recent changes and api removals in mozilla code we are still playing catch up. Currently work with a heavily patches up comm-release and esr60 repo till the catch up in comm-central is finished. Build process is basically identical to Thunderbird and application is comm/suite. comm-central builds are unusable currently.
If you are able to append a conventional patch this would be great. You can set me or Ian Neal as reviewer. If not I or IanN will reformat it and append.

If you plan to do more SeaMonkey patches send me an email and I will help set you up for development.

Test builds are here:
https://www.wg9s.com/comm-253/
We usually add not yet reviewed patches to it for testing. Can do it tomorrow.

I will assign the bug to you.

Comment 24

[Daniel Bomar]

Attachment: documentation-cleanup.patch

Thanks for the info. I'm not entirely clear on what you mean by "old fashioned mercurial patches." Are you saying that SeaMonkey doesn't use the Phabricator site? I've so, I've attached a .patch file from the output of hg diff. This patch is based on the comm-central repo which based on your comment I'm not sure is correct since you said the code in there is not buildable (although I am seeing recent commits to that repo.)

Also, I'm still not sure how to assign a reviewer. Your name isn't popping up on Phabricator when I try to search under "Reviewers" and I don't know how to add a reviewer on Bugzilla if you're not using Phabricator.

Comment 25

[Nuno Silva [:njsg]]

For a more complete mercurial patch with headers, you can use hg export (after committing). (There is also the mq mercurial extension, which is (IMHO) convenient, but, if you don't have it set up, "hg export" is probably simpler for now.)

To set a review flag for your attachment, follow the "details" link: that should lead you to a page where you can modify flags. There, you'd set "review" to "?" and add the reviewer name in the textbox that appears.

Comment 26

[Daniel Bomar]

Attachment: documentation-cleanup-v2.patch

Thanks. Here's the patch in the hg export format and I've marked Frank as the reviewer. Hope that works for you but let me know if you need anything else from me.

Comment 27

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9191206 [details] [diff] [review]
documentation-cleanup-v2.patch

Sorry for the late review. Was busy yesterday. Patch is fine. WIll be in tomorrows unofficial 2.53.6b1 pre. And not to forget thanks.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/650be7afd6a7
Remove reference to unused menu item from help documentation. r=frg

Comment 29

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/41378498883a1027fd61796ae3f65c9e9f5ac5b9
Remove reference to unused menu item from help documentation. r=frg a=frg