Closed
Bug 1270231
Opened 8 years ago
Closed 8 years ago
#define leakage outside of Skia
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
References
Details
Attachments
(1 file)
|
6.83 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Common names such as move, forward, and function were #define'd as part of my workarounds for the Skia update in bug 1265131. This seems to be causing problems with leakage in a few cases, such as bug 1269422.
|
Assignee | |
Comment 1•8 years ago
|
||
This basically makes the actual #define conditional on SKIA_IMPLEMENTATION for use in Skia implementation files. Inside the exported headers, std__foo is used instead, with these always being defined so that they are safe stubs to use inside the headers.
Attachment #8748792 -
Flags: review?(jmuizelaar)
|
||
Updated•8 years ago
|
Attachment #8748792 -
Flags: review?(jmuizelaar) → review+
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0b4b01734a94
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•