1270321 - Ship remember password doorhanger visibility toggle

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P1)

Description

[Matthew N. [:MattN]]

There are a few bugs left before shipping the password visibility toggle that's currently Nightly-only. This meta bug will track the work to ship it.

See attachment 8677036 [details] for a mockup.

Comment 1

[Matthew N. [:MattN]]

Hey Fred, do you want to flip the pref (signon.rememberSignons.visibilityToggle) for all channels and make sure tests still pass?

Comment 2

[[e-mail]]

Attachment: Bug 1270321 - Ship remember password doorhanger visibility toggle;

Review commit: https://reviewboard.mozilla.org/r/72774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72774/

Comment 3

[[e-mail]]

sure! I removed the version detection definition in all.js, also tested on aurora and it works fine

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8782726 [details]
Bug 1270321 - Ship remember password doorhanger visibility toggle;

https://reviewboard.mozilla.org/r/72774/#review70518

Great! Thanks! Looking forward to finally shipping this.

Comment 5

[[e-mail]]

Comment on attachment 8782726 [details]
Bug 1270321 - Ship remember password doorhanger visibility toggle;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72774/diff/1-2/

Comment 6

[[e-mail]]

treeherder result seems fine (2 unrelated error)

Thanks for mentoring this!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d871dea617ac
Ship remember password doorhanger visibility toggle; r=MattN

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d871dea617ac

Comment 9

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to perform Exploratory and Regression testing around the 'Remember password doorhanger visibility toggle' feature and found two minor issues related to this implementation:
- the 'Show password' check box can be enabled/disable by clicking anywhere after the checkbox on the same horizontal line. See 'https://drive.google.com/open?id=0B-cUbHVNThEKU2d2LVF3ajR1MTA'. 
- on Ubuntu OS, the close button 'x', the show password checkbox and the dropdown button are not highlighted when they are selected, by using the Tab key. 
No functional issues were found during testing.
I've also verified the 'Depends on' issues.

As I was saying in the email sent to Matt, if there is no special request, we are treating this issue as regular bug work, since this is a small implementation.

Please let me know if there is something specific that needs to be tested around this feature. 

The tests were performed on Firefox Latest Nightly, under Windows 10x64, Mac OS X 10.11.1 and under Ubuntu 16.04x86

Comment 10

[Gerry Chang [:gchang]]

Added to Fx51 (Aurora) release notes.

Comment 11

[Mihai Boldan, Desktop QA [:mboldan]]

I've also managed to perform Exploratory and Regression testing around the 'Remember password doorhanger visibility toggle' feature on Firefox 51.0b3 and logged Bug 1320677.
The issues from 'Depends on' were also verified.
No functional issues were found.

The tests were performed under Mac OS X 10.11.6, Windows 10x64, Ubuntu 16.04x64.

Please let me know if there is any other information needed.

Comment 12

[Gerry Chang [:gchang]]

In the release notes of 51 with "View passwords from the prompt before saving them" as wording.