Ship remember password doorhanger visibility toggle

VERIFIED FIXED in Firefox 51

Status

()

Toolkit
Password Manager
P1
enhancement
VERIFIED FIXED
2 years ago
11 months ago

People

(Reporter: MattN, Assigned: gasolin)

Tracking

({feature, meta})

unspecified
mozilla51
feature, meta
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(relnote-firefox 51+, firefox51 verified)

Details

(Whiteboard: [passwords:capture-UI])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

There are a few bugs left before shipping the password visibility toggle that's currently Nightly-only. This meta bug will track the work to ship it.

See attachment 8677036 [details] for a mockup.
Flags: qe-verify+
Whiteboard: [passwords:capture-UI]
Priority: -- → P1
Hey Fred, do you want to flip the pref (signon.rememberSignons.visibilityToggle) for all channels and make sure tests still pass?
Flags: needinfo?(gasolin)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
sure! I removed the version detection definition in all.js, also tested on aurora and it works fine
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Flags: needinfo?(gasolin)
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8782726 [details]
Bug 1270321 - Ship remember password doorhanger visibility toggle;

https://reviewboard.mozilla.org/r/72774/#review70518

Great! Thanks! Looking forward to finally shipping this.
Attachment #8782726 - Flags: review?(MattN+bmo) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a year ago
treeherder result seems fine (2 unrelated error)

Thanks for mentoring this!
Keywords: checkin-needed

Comment 7

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d871dea617ac
Ship remember password doorhanger visibility toggle; r=MattN
Keywords: checkin-needed

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d871dea617ac
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
I managed to perform Exploratory and Regression testing around the 'Remember password doorhanger visibility toggle' feature and found two minor issues related to this implementation:
- the 'Show password' check box can be enabled/disable by clicking anywhere after the checkbox on the same horizontal line. See 'https://drive.google.com/open?id=0B-cUbHVNThEKU2d2LVF3ajR1MTA'. 
- on Ubuntu OS, the close button 'x', the show password checkbox and the dropdown button are not highlighted when they are selected, by using the Tab key. 
No functional issues were found during testing.
I've also verified the 'Depends on' issues.

As I was saying in the email sent to Matt, if there is no special request, we are treating this issue as regular bug work, since this is a small implementation.

Please let me know if there is something specific that needs to be tested around this feature. 

The tests were performed on Firefox Latest Nightly, under Windows 10x64, Mac OS X 10.11.1 and under Ubuntu 16.04x86
Added to Fx51 (Aurora) release notes.
relnote-firefox: --- → 51+
Depends on: 1320677
I've also managed to perform Exploratory and Regression testing around the 'Remember password doorhanger visibility toggle' feature on Firefox 51.0b3 and logged Bug 1320677.
The issues from 'Depends on' were also verified.
No functional issues were found.

The tests were performed under Mac OS X 10.11.6, Windows 10x64, Ubuntu 16.04x64.

Please let me know if there is any other information needed.
Status: RESOLVED → VERIFIED
status-firefox51: fixed → verified

Comment 12

11 months ago
In the release notes of 51 with "View passwords from the prompt before saving them" as wording.
You need to log in before you can comment on or make changes to this bug.