Closed
Bug 1270326
Opened 8 years ago
Closed 8 years ago
Intermittent testDistribution | check android.distribution.test.boolean - got false, expected true
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(firefox49 fixed, firefox50 fixed, firefox51 fixed)
RESOLVED
FIXED
Firefox 51
People
(Reporter: philor, Assigned: gbrown)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.60 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•8 years ago
|
||
This has been happening since at least Apr 28, https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=541618e4babd163b57da0ca1b2fae052c1bcde0c, http://archive.mozilla.org/pub/mobile/tinderbox-builds/mozilla-inbound-android-api-15/1461874249/mozilla-inbound_ubuntu64_vm_armv7_mobile_test-robocop-1-bm68-tests1-linux64-build1027.txt.gz.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
status-firefox50:
--- → affected
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 16•8 years ago
|
||
Logcats for these failures show an exception earlier, in initDistribution(): 08-08 22:47:44.373 2059 2072 I Robocop : {"action":"log","message":"No distribution to clear from \/data\/data\/org.mozilla.fennec\/distribution","time":1470721664375,"pid":null,"level":"info","source":"robocop","thread":null} 08-08 22:47:44.393 2059 2072 D Robocop : waiting for Distribution:Set:OK 08-08 22:47:44.403 2059 2072 D GeckoDistribution: Getting file from distribution. 08-08 22:47:44.414 2059 2073 D GeckoDistribution: Creating /data/data/org.mozilla.fennec/distribution 08-08 22:47:44.423 2059 2072 D GeckoDistribution: Creating /data/data/org.mozilla.fennec/distribution 08-08 22:47:44.433 2059 2072 D GeckoDistribution: Creating /data/data/org.mozilla.fennec/distribution/extensions 08-08 22:47:44.443 2059 2072 D GeckoDistribution: Creating /data/data/org.mozilla.fennec/distribution/searchplugins/common 08-08 22:47:44.453 2059 2073 E GeckoDistribution: Unable to create directories: /data/data/org.mozilla.fennec/distribution 08-08 22:47:44.453 2059 2072 D GeckoDistribution: Creating /data/data/org.mozilla.fennec/distribution/suggestedsites/locales/en-US 08-08 22:47:44.483 2059 2072 E GeckoDistribution: Error getting distribution descriptor file. 08-08 22:47:44.483 2059 2072 E GeckoDistribution: java.io.IOException: Given file is empty - the JSON parser cannot create an object from an empty file 08-08 22:47:44.483 2059 2072 E GeckoDistribution: at org.mozilla.gecko.util.FileUtils.readJSONObjectFromFile(FileUtils.java:110) 08-08 22:47:44.483 2059 2072 E GeckoDistribution: at org.mozilla.gecko.distribution.Distribution.getAndroidPreferences(Distribution.java:399) 08-08 22:47:44.483 2059 2072 E GeckoDistribution: at org.mozilla.gecko.preferences.DistroSharedPrefsImport.importPreferences(DistroSharedPrefsImport.java:28) 08-08 22:47:44.483 2059 2072 E GeckoDistribution: at org.mozilla.gecko.tests.testDistribution.initDistribution(testDistribution.java:289) 08-08 22:47:44.483 2059 2072 E GeckoDistribution: at org.mozilla.gecko.tests.testDistribution.testDistribution(testDistribution.java:144) 08-08 22:47:44.483 2059 2072 E GeckoDistribution: at java.lang.reflect.Method.invokeNative(Native Method)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gbrown
Assignee | ||
Comment 17•8 years ago
|
||
I'm no distribution expert, but I think this makes sense: Wait for notification that the init is complete before trying to read prefs. https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba1fe71be644 suggests this is effective.
Attachment #8779548 -
Flags: review?(snorp)
Comment on attachment 8779548 [details] [diff] [review] improve wait for distribution init Review of attachment 8779548 [details] [diff] [review]: ----------------------------------------------------------------- I'm no expert either, but it does seem to make sense.
Attachment #8779548 -
Flags: review?(snorp) → review+
Comment 19•8 years ago
|
||
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ed079c982977 Improve wait for initialization in robocop testDistribution; r=snorp
Comment hidden (Intermittent Failures Robot) |
Comment 21•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ed079c982977
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment 22•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/b28e94ad6314
Comment 23•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/c4a150c631ae
Comment hidden (Intermittent Failures Robot) |
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•