1270329 - Use-after-forget in WebMTrackDemuxer::SkipToNextRandomAccessPoint

Status: RESOLVED DUPLICATE of bug 1261900

(Core :: Audio/Video: Playback, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

It looks like this will be a null pointer crash if logging is enabled:

      mSamples.PushFront(sample.forget());

followed by:

    WEBM_DEBUG("next sample: %f (parsed: %d)",
               media::TimeUnit::FromMicroseconds(sample->mTime).ToSeconds(),
               parsed);

It looks like bug 1190472 regressed this.  Found with the static analysis patches in bug 1186706 (after un-bit-rotting them to test bug 1191452).

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug1270329-webm-sampletime-hg0.diff

Comment 2

[Jean-Yves Avenard [:jya]]

I've fixed that one in the pending bug 1261900 (patch 9)