Closed Bug 1270338 Opened 5 years ago Closed 5 years ago

Add a mochitest to ensure Sanitizer clears data for all containers

Categories

(Core :: DOM: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox49 --- affected
firefox53 --- fixed

People

(Reporter: allstars.chh, Assigned: jhao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [userContextId][OA-testing][domsecurity-backlog2][tor-testing])

Attachments

(1 file)

This bug is to make sure "Clear History" will apply for all containers for v1.
For v2 we'd like to have to clear history for some specific container, bug 1199470.
Priority: -- → P1
Whiteboard: [userContextId] → [userContextId][OA][domsecurity-active]
Recently I implemented a ContextualIdentity service. What about if we use this component to retrieve the list of userContextIds and delete everything based on this list?
Assignee: allstars.chh → nobody
Assignee: nobody → tihuang
Status: NEW → ASSIGNED
It appears that the clear history works correctly for clearing all user contexts. The clear history is based on the sanitizer[1] and the sanitizer does the right thing. The sanitizer has been tested in the Bug 1250983 that the forget button uses the sanitizer to clear data as well, and the forget button did clear all user contexts. 

So I think we should make this bug as an OA-testing bug, and move it to P2.

What do you think, Tanvi?

[1] https://dxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js
Flags: needinfo?(tanvi)
What is different about Clearing History and clicking the Forget button?  Do they both do the same thing?

Tim, if you have tested manually and confirmed that clearing works, then we can covert this to a P2 testing bug.

Thank you!
Flags: needinfo?(tanvi)
Priority: P1 → P2
Whiteboard: [userContextId][OA][domsecurity-active] → [userContextId][OA-testing][domsecurity-active]
Summary: Clear History for all containers → Add a mochitest to ensure Clear History clears data for all containers
Status: ASSIGNED → NEW
Assignee: tihuang → nobody
Whiteboard: [userContextId][OA-testing][domsecurity-active] → [userContextId][OA-testing][domsecurity-backlog]
Priority: P2 → P3
Whiteboard: [userContextId][OA-testing][domsecurity-backlog] → [userContextId][OA-testing][domsecurity-backlog2]
Priority: P3 → P2
Whiteboard: [userContextId][OA-testing][domsecurity-backlog2] → [userContextId][OA-testing][domsecurity-backlog2][tor-testing]
Assignee: nobody → jhao
Status: NEW → ASSIGNED
Blocks: 1250983
Summary: Add a mochitest to ensure Clear History clears data for all containers → Add a mochitest to ensure Sanitizer clears data for all containers
Comment on attachment 8818197 [details]
Bug 1270338 - Add a mochitest to ensure Sanitizer clears data for all containers.

https://reviewboard.mozilla.org/r/98332/#review101478

Sorry for the delay.  Thanks for answering my questions.  This looks good.  Please add a cache test.
Attachment #8818197 - Flags: review?(tanvi) → review+
I added a test to ensure cache is cleared.  I also removed the nested add_task in head.js so that I can add my own task after IsolationTestTools.runTest().

Baku, since Tanvi already r+'d, could you take a look?
Comment on attachment 8818197 [details]
Bug 1270338 - Add a mochitest to ensure Sanitizer clears data for all containers.

https://reviewboard.mozilla.org/r/98332/#review103014
Attachment #8818197 - Flags: review?(amarchesini) → review+
Pushed by jhao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21a56b3ad9e4
Add a mochitest to ensure Sanitizer clears data for all containers. r=baku,tanvi
https://hg.mozilla.org/mozilla-central/rev/21a56b3ad9e4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Jonathan, thanks for getting this done!
Duplicate of this bug: 1250983
You need to log in before you can comment on or make changes to this bug.