1270338 - Add a mochitest to ensure Sanitizer clears data for all containers

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This bug is to make sure "Clear History" will apply for all containers for v1.
For v2 we'd like to have to clear history for some specific container, bug 1199470.

Comment 1

[Andrea Marchesini [:baku]]

Recently I implemented a ContextualIdentity service. What about if we use this component to retrieve the list of userContextIds and delete everything based on this list?

Comment 2

[Tim Huang[:timhuang]]

It appears that the clear history works correctly for clearing all user contexts. The clear history is based on the sanitizer[1] and the sanitizer does the right thing. The sanitizer has been tested in the Bug 1250983 that the forget button uses the sanitizer to clear data as well, and the forget button did clear all user contexts. 

So I think we should make this bug as an OA-testing bug, and move it to P2.

What do you think, Tanvi?

[1] https://dxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js

Comment 3

[Tanvi Vyas[:tanvi]]

What is different about Clearing History and clicking the Forget button?  Do they both do the same thing?

Tim, if you have tested manually and confirmed that clearing works, then we can covert this to a P2 testing bug.

Thank you!

Comment 4

[Jonathan Hao (inactive) [:jhao]]

Attachment: Bug 1270338 - Add a mochitest to ensure Sanitizer clears data for all containers.

Review commit: https://reviewboard.mozilla.org/r/98332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98332/

Comment 5

[Jonathan Hao (inactive) [:jhao]]

Comment on attachment 8818197 [details]
Bug 1270338 - Add a mochitest to ensure Sanitizer clears data for all containers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98332/diff/1-2/

Comment 6

[Tanvi Vyas[:tanvi]]

Comment on attachment 8818197 [details]
Bug 1270338 - Add a mochitest to ensure Sanitizer clears data for all containers.

https://reviewboard.mozilla.org/r/98332/#review101478

Sorry for the delay.  Thanks for answering my questions.  This looks good.  Please add a cache test.

Comment 7

[Jonathan Hao (inactive) [:jhao]]

Comment on attachment 8818197 [details]
Bug 1270338 - Add a mochitest to ensure Sanitizer clears data for all containers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98332/diff/2-3/

Comment 8

[Jonathan Hao (inactive) [:jhao]]

I added a test to ensure cache is cleared.  I also removed the nested add_task in head.js so that I can add my own task after IsolationTestTools.runTest().

Baku, since Tanvi already r+'d, could you take a look?

Comment 9

[Jonathan Hao (inactive) [:jhao]]

Comment on attachment 8818197 [details]
Bug 1270338 - Add a mochitest to ensure Sanitizer clears data for all containers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98332/diff/3-4/

Comment 10

[Andrea Marchesini [:baku]]

Comment on attachment 8818197 [details]
Bug 1270338 - Add a mochitest to ensure Sanitizer clears data for all containers.

https://reviewboard.mozilla.org/r/98332/#review103014

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21a56b3ad9e4
Add a mochitest to ensure Sanitizer clears data for all containers. r=baku,tanvi

Comment 12

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/21a56b3ad9e4

Comment 13

[Ethan Tseng [:ethan]]

Jonathan, thanks for getting this done!