127036 - from compose and addressbook window, "File | New | Blank Page to Edit" doesn't work

Status: VERIFIED DUPLICATE of bug 122271

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

from compose window, "File | New | Blank Page to Edit" doesn't work

JavaScript error:
 line 0: NewEditorWindow is not defined

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: a potential fix, but there might be side effects

here's a patch that fixes the problem, but there might be side effects, I
haven't finished testing.

on possible side effect:

I'm seeing this on the console, not sure yet if it was there before:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "popup has no properties" {file:
"chrome://ed
itor/content/editorApplicationOverlay.js" line: 55}]' when calling method:
[nsID
OMEventListener::handleEvent]"	nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_E
RROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
************************************************************

Comment 2

[(not reading, please use [e-mail] instead)]

I believe this patch to be correct, but I'm nervous about side effects, 
specifically, the xul and js that we're now bringing in affects msg compose 
functionatily, or performance.

the new error on the console is caused by some js in 
editorApplicationOverlay.js.

on load, we call a js function that does getElementById 
on "contentAreaContextMenu"

in this case, we don't have that.  (I'm haven't researched any further).

over to varada for finish up this patch.

Comment 3

[varada]

The code to execute NewEditorWindow was moved from utilityOverlay.js to
editorApplicationOverlay.js and two new overlays were added to contend with the
navigator and mail but not addressbook and mailcompose. CManske said that he
plans to modularise this so that other applications will have to look in just
one place for editor overlays. There is no necessity to add the
editorMailOverlay.xul or to create a new ones for addressbook and mailcompose
instead we can just add the editorApplicationOverlay.js to the xul files ( as a
temporary solution till the changes are done) or even simpler add this function
to the JS since all it does is open a blank editor window.
function NewEditorWindow()
{
  window.openDialog( "chrome://editor/content", "_blank",
"chrome,all,dialog=no", "about:blank");
}
CCing cmanske.
Changing summary to add addressbook.

Comment 4

[varada]

Attachment: Patch V2

Added the NewEditorWindow() function to the addressbook and messengercompose js
files. This is a temp hack till the editor overlay reworking is done. cmanske
can I get an r on this ?

Comment 5

[Charles Manske]

Is this critical for 0.9.9? It will be fixed by the patch for bug 122271, which
I planned to checkin immediately after 1.0 opens

Comment 6

[scottputterman]

It's not critical. Can this be marked as a dup of 122271 if it's going to fix this?

Comment 7

[Charles Manske]

Duping sounds like a good idea to me!

*** This bug has been marked as a duplicate of 122271 ***

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

verified dup.