Closed
Bug 1270387
Opened 8 years ago
Closed 8 years ago
Disable Node.rootNode in release builds due to web compatibility issues
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: yrliou, Assigned: yrliou)
References
Details
(Keywords: dev-doc-complete, site-compat, Whiteboard: btpp-active)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
smaug
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
See https://github.com/whatwg/dom/issues/241 As for now, both blink and safari unship this feature. Before having a new name in the spec, we will use a preference to disable this feature in release builds first. After spec being revised, remove the preference and adopt the change in Bug 1269155.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50727/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50727/
Attachment #8749056 -
Flags: review?(bugs)
Updated•8 years ago
|
Attachment #8749056 -
Flags: review?(bugs) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8749056 [details] MozReview Request: Bug 1270387 - Disable Node.rootNode in release builds due to web compatibility issues. r?smaug https://reviewboard.mozilla.org/r/50727/#review47429 And we need to get this to aurora (FF48) right? So ask approval for the patch to land there too.
Updated•8 years ago
|
Whiteboard: btpp-active
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/49dab7b4a276
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8749056 [details] MozReview Request: Bug 1270387 - Disable Node.rootNode in release builds due to web compatibility issues. r?smaug Approval Request Comment [Feature/regressing bug #]: Bug 1254956 [User impact if declined]: Web compatibility issues have been brought up and discussed at https://github.com/whatwg/dom/issues/241, both safari and blink unshipped this feature. [Describe test coverage new/current, TreeHerder]: There are web platform tests for this feature which are still enabled, we only turn off the preference and disable this feature in release builds. [Risks and why]: Low, just add a pref and turn it off in release builds [String/UUID change made/needed]: None
Attachment #8749056 -
Flags: approval-mozilla-aurora?
Comment 6•8 years ago
|
||
Comment on attachment 8749056 [details] MozReview Request: Bug 1270387 - Disable Node.rootNode in release builds due to web compatibility issues. r?smaug Part of deprecation strategy, has some test coverage, please uplift to aurora
Attachment #8749056 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•8 years ago
|
||
Jocelyn should this have a release note? Or maybe more likely, does it need developer documentation?
status-firefox48:
--- → affected
Keywords: dev-doc-needed
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/1956edae83a4
Assignee | ||
Comment 9•8 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #7) > Jocelyn should this have a release note? Or maybe more likely, does it need > developer documentation? Yes, I think we should have docs for specifying the new preference. Documentation of rootNode was written since Bug 1254956, we should probably revise those existing docs and the 48 release note.
See Also: → 1254956
Updated•8 years ago
|
Keywords: site-compat
Comment 10•8 years ago
|
||
Added banners in https://developer.mozilla.org/en-US/docs/Web/API/Node/rootNode and removed from https://developer.mozilla.org/en-US/Firefox/Releases/48
Keywords: dev-doc-needed → dev-doc-complete
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•