Disable Node.rootNode in release builds due to web compatibility issues

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: yrliou, Assigned: yrliou)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
See https://github.com/whatwg/dom/issues/241
As for now, both blink and safari unship this feature.

Before having a new name in the spec, we will use a preference to disable this feature in release builds first.

After spec being revised, remove the preference and adopt the change in Bug 1269155.
Attachment #8749056 - Flags: review?(bugs) → review+
Comment on attachment 8749056 [details]
MozReview Request: Bug 1270387 - Disable Node.rootNode in release builds due to web compatibility issues. r?smaug

https://reviewboard.mozilla.org/r/50727/#review47429

And we need to get this to aurora (FF48) right? So ask approval for the patch to land there too.
Whiteboard: btpp-active

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/49dab7b4a276
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
(Assignee)

Comment 5

3 years ago
Comment on attachment 8749056 [details]
MozReview Request: Bug 1270387 - Disable Node.rootNode in release builds due to web compatibility issues. r?smaug

Approval Request Comment
[Feature/regressing bug #]: Bug 1254956
[User impact if declined]: Web compatibility issues have been brought up and discussed at https://github.com/whatwg/dom/issues/241, both safari and blink unshipped this feature. 
[Describe test coverage new/current, TreeHerder]: There are web platform tests for this feature which are still enabled, we only turn off the preference and disable this feature in release builds.
[Risks and why]: Low, just add a pref and turn it off in release builds
[String/UUID change made/needed]: None
Attachment #8749056 - Flags: approval-mozilla-aurora?
Comment on attachment 8749056 [details]
MozReview Request: Bug 1270387 - Disable Node.rootNode in release builds due to web compatibility issues. r?smaug

Part of deprecation strategy, has some test coverage, please uplift to aurora
Attachment #8749056 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Jocelyn should this have a release note? Or maybe more likely, does it need developer documentation?
(Assignee)

Comment 9

3 years ago
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #7)
> Jocelyn should this have a release note? Or maybe more likely, does it need
> developer documentation?

Yes, I think we should have docs for specifying the new preference.
Documentation of rootNode was written since Bug 1254956, we should probably revise those existing docs and the 48 release note.
See Also: → 1254956
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.