Closed
Bug 1270392
Opened 8 years ago
Closed 8 years ago
[TV][Home] In card selection page of creating folder, the Done button always enabled
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)
Tracking
(blocking-b2g:2.6+)
VERIFIED
FIXED
| blocking-b2g | 2.6+ |
People
(Reporter: mlien, Assigned: Fischer)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
[Description] According to the latest UX spec(https://drive.google.com/open?id=0BwbmH5cX2W6Od0EwMXpSWlFwcDQ), if user doesn't select any card in card selection page, the Done button should be dimmed [Testing Steps] 1. Focus on any card 2. Navigate to Add folder then press OK key [Expected result] The Done button should be dimmed if there's no any card selected [Actual result] The Done button is always enabled [Build Info] Environment: 2.6 Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/4698bb1d24fac0db76f1f16f144cf0dae4bc3c23 gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/ccf59a9dda868db58b5d943e2c4235ead89f9344
|
||
Updated•8 years ago
|
blocking-b2g: 2.6? → 2.6+
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → fliu
|
|
Assignee | |
Comment 1•8 years ago
|
||
@Jack, Per the discussion, could you please update the specs and confirm that when adding folder, hide the Done button if no card is selected. So the QA team can verify this bug. Thanks.
Flags: needinfo?(jalin)
|
||
Comment 2•8 years ago
|
||
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8752650 [details] [review] [gaia] Fischer-L:bug_1270392-disable-don-btn-if-no-card-selected > mozilla-b2g:v2.6 @Luke, This patch hided the Done button if no card is selected when adding new folder according to the new specs, thanks.
Attachment #8752650 -
Flags: review?(lchang)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8752650 [details] [review] [gaia] Fischer-L:bug_1270392-disable-don-btn-if-no-card-selected > mozilla-b2g:v2.6 Looks good! Thanks.
Attachment #8752650 -
Flags: review?(lchang) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/5905f19e66bed253b20ff585fb5ea759884616c5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 6•8 years ago
|
||
verified and fixed with below build: 2.6 simulator gaia: https://github.com/mozilla-b2g/gaia/commit/9a3ed0cb72e84628ca6c2c3e5b9fc4f419059268 gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/ccf59a9dda868db58b5d943e2c4235ead89f9344
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Flags: needinfo?(jalin)
You need to log in
before you can comment on or make changes to this bug.
Description
•