1270399 - [TV][Home] Navigation in filter doesn't support to wrap around in both directions

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)

Description

[Mike Lien[:mlien]]

[Description]
According to the latest UX spec(https://drive.google.com/open?id=0BwbmH5cX2W6Od0EwMXpSWlFwcDQ), if user navigates in filter, it should wrap around in both directions

[Testing Steps]
1. Navigation to filter
2. Move to left most filter then press left arrow key again
3. Move to right most filter then press right arrow key again

[Expected result]
Navigation should support to wrap around in both directions

[Actual result]
Navigation doesn't support to wrap around in both directions

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/4698bb1d24fac0db76f1f16f144cf0dae4bc3c23
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/ccf59a9dda868db58b5d943e2c4235ead89f9344

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1270399_tv_filter_wrap_around > mozilla-b2g:v2.6

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8751627 [details] [review]
[gaia] luke-chang:1270399_tv_filter_wrap_around > mozilla-b2g:v2.6

Hi Rex,

In order to fulfill future requests, I added a new API to SpatialNavigator to support customized navigating rules via data attributes. Could you take a look? Thanks.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8751627 [details] [review]
[gaia] luke-chang:1270399_tv_filter_wrap_around > mozilla-b2g:v2.6

awesome!

Comment 4

[Luke Chang [:lchang] (inactive)]

Rex, Thanks a lot!


landed on v2.6: https://github.com/mozilla-b2g/gaia/commit/257e64ab5b98fbf78e846fce74355015c4452489

Comment 5

[Mike Lien[:mlien]]

verified and fixed with the latest build
2.6 simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/c5cceac45c13eab6a297074d55261610d8a0880f
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/425aaa9763aef80ec1f7e78079e410ee1ccc9e32