1270432 - MenuView: add long press actions to MenuItems.

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[James Hugman [:jhugman] [@jhugman]]

The menu delegate should should process the long press actions in the same way as for normal actions, i.e. in MenuActionDelegate.

Comment 1

[James Hugman [:jhugman] [@jhugman]]

If and when we want to support user re-ordering/removal of menu items within the same menu, this bug will mean we can't use long press to switch into menu edit mode.

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Should there be any visual difference to indicate that there is a secondary action behind this menu? (e.g. 'Home…', or a different tint?)

Also: note to self: update the HIG docs for MenuView around secondary actions must have a confirmation dialog.

Comment 3

[Sevaan Franks [:sevaan]]

Let's descope the long-press on the home button. A user can still change their home page via settings, and we can spend a little more time thinking on this.

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Attachment: Pull request

Added support for MenuItems and MenuToolbarItems.

Comment 5

[James Hugman [:jhugman] [@jhugman]]

I have contradictory thoughts on this, mostly based on a sunk cost fallacy.

Do we want to land this anyway and refine it or is it the opportunity cost of using up the long press gesture?

Comment 6

[Emily Toop (:fluffyemily)]

Comment on attachment 8749593 [details] [review]
Pull request

LGTM. Just a couple of small things.

Comment 7

[Sevaan Franks [:sevaan]]

(In reply to James Hugman [:jhugman] [@jhugman] from comment #5)
> Do we want to land this anyway and refine it or is it the opportunity cost
> of using up the long press gesture?

I think it's the latter. If we eventually want users to be able to customize their menus (removing items, rearranging icons) then the natural way to do this on IOS is to long press on an icon to enter this edit mode.

Long-pressing the Home button to change the homepage again is also not discoverable, and I also don't believe users will be changing their home pages often enough that a short  cut is warranted.

Comment 8

[James Hugman [:jhugman] [@jhugman]]

This is a great reply, thanks.

Is there anything to be saved from this PR even if we don't use it in the product? e.g. 3D touch?

(:fluffyemily and I have an eye on splitting the menu out as a separate project)

Comment 9

[James Hugman [:jhugman] [@jhugman]]

This is a great reply, thanks.

Is there anything to be saved from this PR even if we don't use it in the product? e.g. use a 3D touch gesture?

(:fluffyemily and I have an eye on splitting the menu out as a separate project)

Comment 10

[James Hugman [:jhugman] [@jhugman]]

Addressed nits, and rebased. Not merged.

Comment 11

[James Hugman [:jhugman] [@jhugman]]

Merged though unused by homepage.

Comment 12

[Sevaan Franks [:sevaan]]

> Is there anything to be saved from this PR even if we don't use it in the
> product? e.g. use a 3D touch gesture?

3D Touch is a great idea. I just reviewed the HIG and no red flags have been raised. We should totally use it for this button to reset the current page as Home. It's a tiny, secret little shortcut, but could be handy. And those without devices that support 3D Touch can still edit their page through the Settings.