1270446 - Improve toolchain.configure tests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

I've had these changes sitting in my queue for 2 weeks...

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1270446 - Make check_compiler() return a namespace instead of a tuple. r?chmanchester

Review commit: https://reviewboard.mozilla.org/r/50771/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50771/

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1270446 - Move CompilerPreprocessor, FakeCompiler and their tests to a separate file. r?chmanchester

This makes the toolchain.configure tests more prominent in the file.

Review commit: https://reviewboard.mozilla.org/r/50773/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50773/

Comment 3

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1270446 - Allow to combine multiple FakeCompiler definitions. r?chmanchester

Review commit: https://reviewboard.mozilla.org/r/50775/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50775/

Comment 4

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1270446 - Simplify the fake compiler definitions. r?chmanchester

Originally, the changes to FakeCompiler allowing overlays was meant to
be used for compiler target platform, but it turns out the
simplifications this allows on the compiler definitions themselves are
nice.

Review commit: https://reviewboard.mozilla.org/r/50777/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50777/

Comment 5

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1270446 - Make it easier to derive compiler results. r?chmanchester

Review commit: https://reviewboard.mozilla.org/r/50779/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50779/

Comment 6

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1270446 - Automatically add --target argument when unit test class has a TARGET attribute. r?chmanchester

Review commit: https://reviewboard.mozilla.org/r/50781/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50781/

Comment 7

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8749133 [details]
MozReview Request: Bug 1270446 - Make check_compiler() return a namespace instead of a tuple. r?chmanchester

https://reviewboard.mozilla.org/r/50771/#review47599

Comment 8

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8749134 [details]
MozReview Request: Bug 1270446 - Move CompilerPreprocessor, FakeCompiler and their tests to a separate file. r?chmanchester

https://reviewboard.mozilla.org/r/50773/#review47605

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8749135 [details]
MozReview Request: Bug 1270446 - Allow to combine multiple FakeCompiler definitions. r?chmanchester

https://reviewboard.mozilla.org/r/50775/#review47609

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8749136 [details]
MozReview Request: Bug 1270446 - Simplify the fake compiler definitions. r?chmanchester

https://reviewboard.mozilla.org/r/50777/#review47613

Comment 11

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8749137 [details]
MozReview Request: Bug 1270446 - Make it easier to derive compiler results. r?chmanchester

https://reviewboard.mozilla.org/r/50779/#review47617

::: python/mozbuild/mozbuild/test/configure/test_toolchain_helpers.py:353
(Diff revision 1)
> +    def __add__(self, other):
> +        assert isinstance(other, dict)

It's a little funny to see a '+' implemented that isn't commutative.

Comment 12

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8749138 [details]
MozReview Request: Bug 1270446 - Automatically add --target argument when unit test class has a TARGET attribute. r?chmanchester

https://reviewboard.mozilla.org/r/50781/#review47625

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6faf0619a211
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e38b67846f1
https://hg.mozilla.org/integration/mozilla-inbound/rev/471bf0db2843
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc14a8472950
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3573274d787
https://hg.mozilla.org/integration/mozilla-inbound/rev/61bae26a46bc

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6faf0619a211
https://hg.mozilla.org/mozilla-central/rev/8e38b67846f1
https://hg.mozilla.org/mozilla-central/rev/471bf0db2843
https://hg.mozilla.org/mozilla-central/rev/cc14a8472950
https://hg.mozilla.org/mozilla-central/rev/c3573274d787
https://hg.mozilla.org/mozilla-central/rev/61bae26a46bc