Improve toolchain.configure tests

RESOLVED FIXED in Firefox 49

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks 1 bug)

unspecified
mozilla49
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(6 attachments)

I've had these changes sitting in my queue for 2 weeks...
Review commit: https://reviewboard.mozilla.org/r/50771/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50771/
Attachment #8749133 - Flags: review?(cmanchester)
Attachment #8749134 - Flags: review?(cmanchester)
Attachment #8749135 - Flags: review?(cmanchester)
Attachment #8749136 - Flags: review?(cmanchester)
Attachment #8749137 - Flags: review?(cmanchester)
Attachment #8749138 - Flags: review?(cmanchester)
Originally, the changes to FakeCompiler allowing overlays was meant to
be used for compiler target platform, but it turns out the
simplifications this allows on the compiler definitions themselves are
nice.

Review commit: https://reviewboard.mozilla.org/r/50777/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50777/
Comment on attachment 8749133 [details]
MozReview Request: Bug 1270446 - Make check_compiler() return a namespace instead of a tuple. r?chmanchester

https://reviewboard.mozilla.org/r/50771/#review47599
Attachment #8749133 - Flags: review?(cmanchester) → review+
Comment on attachment 8749134 [details]
MozReview Request: Bug 1270446 - Move CompilerPreprocessor, FakeCompiler and their tests to a separate file. r?chmanchester

https://reviewboard.mozilla.org/r/50773/#review47605
Attachment #8749134 - Flags: review?(cmanchester) → review+
Comment on attachment 8749135 [details]
MozReview Request: Bug 1270446 - Allow to combine multiple FakeCompiler definitions. r?chmanchester

https://reviewboard.mozilla.org/r/50775/#review47609
Attachment #8749135 - Flags: review?(cmanchester) → review+
Comment on attachment 8749136 [details]
MozReview Request: Bug 1270446 - Simplify the fake compiler definitions. r?chmanchester

https://reviewboard.mozilla.org/r/50777/#review47613
Attachment #8749136 - Flags: review?(cmanchester) → review+
Attachment #8749137 - Flags: review?(cmanchester) → review+
Comment on attachment 8749137 [details]
MozReview Request: Bug 1270446 - Make it easier to derive compiler results. r?chmanchester

https://reviewboard.mozilla.org/r/50779/#review47617

::: python/mozbuild/mozbuild/test/configure/test_toolchain_helpers.py:353
(Diff revision 1)
> +    def __add__(self, other):
> +        assert isinstance(other, dict)

It's a little funny to see a '+' implemented that isn't commutative.
Comment on attachment 8749138 [details]
MozReview Request: Bug 1270446 - Automatically add --target argument when unit test class has a TARGET attribute. r?chmanchester

https://reviewboard.mozilla.org/r/50781/#review47625
Attachment #8749138 - Flags: review?(cmanchester) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.