Closed Bug 1270447 Opened 4 years ago Closed 3 years ago

Printing via parent fails when using pref print.always_print_silent=true

Categories

(Core :: Printing: Output, defect)

All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

(Keywords: regression, Whiteboard: sbwc1)

Attachments

(4 files)

+++ This bug was initially created as a clone of Bug #1255336 +++

Breaking this out from bug 1255336 as the reported problem there turned out to be a separate issue.

This fails because a RemotePrintJob hasn't been set up when printing silently.
Bob: Does this only affect Firefox 49 or other versions, and do we have STR?
Flags: needinfo?(bobowen.code)
(In reply to Marcia Knous [:marcia - use ni] from comment #1)
> Bob: Does this only affect Firefox 49 or other versions, and do we have STR?

Just Fx49, in fact it's Nightly only until we start to roll out the content sandbox, but that will hopefully be in Fx49.

STR are just to create print.always_print_silent=true pref on Windows and attempt to print.
(Assuming you're running with e10s and print.print_via_parent=true, which is the default.)

I'll be picking this up soon, anyway.
Assignee: nobody → bobowen.code
Status: NEW → ASSIGNED
Flags: needinfo?(bobowen.code)
No longer depends on: 1236015
Comment on attachment 8755845 [details]
MozReview Request: Bug 1270447 Part 1: Use the RemotePrintJob's print settings in the parent when available.

https://reviewboard.mozilla.org/r/54842/#review52196

::: layout/printing/ipc/RemotePrintJobParent.cpp:203
(Diff revision 1)
>    MOZ_ASSERT(aListener);
>  
>    mPrintProgressListeners.AppendElement(aListener);
>  }
>  
> +already_AddRefed<nsIPrintSettings> RemotePrintJobParent::GetPrintSettings()

nit - wrap this such that the return type is above the method name. looks like that matches the rest of the file.
Attachment #8755845 - Flags: review?(jmathies) → review+
Comment on attachment 8755846 [details]
MozReview Request: Bug 1270447 Part 2: Fix to use the correct print settings in PrintingParent::SerializeAndEnsureRemotePrintJob.

https://reviewboard.mozilla.org/r/54844/#review52200
Attachment #8755846 - Flags: review?(jmathies) → review+
Attachment #8755847 - Flags: review?(jmathies) → review+
Comment on attachment 8755847 [details]
MozReview Request: Bug 1270447 Part 3: Authorize silent printing via the parent.

https://reviewboard.mozilla.org/r/54846/#review52202
Comment on attachment 8755848 [details]
MozReview Request: Bug 1270447 Part 4: Remove redundant lines in nsPrintOptionsWin::DeserializeToPrintSettings.

https://reviewboard.mozilla.org/r/54848/#review52204
Attachment #8755848 - Flags: review?(jmathies) → review+
Comment on attachment 8755845 [details]
MozReview Request: Bug 1270447 Part 1: Use the RemotePrintJob's print settings in the parent when available.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54842/diff/1-2/
Comment on attachment 8755846 [details]
MozReview Request: Bug 1270447 Part 2: Fix to use the correct print settings in PrintingParent::SerializeAndEnsureRemotePrintJob.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54844/diff/1-2/
Comment on attachment 8755847 [details]
MozReview Request: Bug 1270447 Part 3: Authorize silent printing via the parent.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54846/diff/1-2/
Comment on attachment 8755848 [details]
MozReview Request: Bug 1270447 Part 4: Remove redundant lines in nsPrintOptionsWin::DeserializeToPrintSettings.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54848/diff/1-2/
You need to log in before you can comment on or make changes to this bug.