1270454 - Allow skipping the Heroku pre_deploy script entirely by defining 'SKIP_PREDEPLOY'

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, defect, P2)

Description

[Ed Morley [:emorley]]

By default, the bin/pre_deploy script that runs as part of a Heroku deploy will cause the deploy to abort if errors occurred.

These errors can be made non-fatal by defining IGNORE_PREDEPLOY_ERRORS in the environment.

However there are still cases where we don't want to even try to run the deploy script - for example when standing up a new Heroku instance, and we don't want the migrations to run until we're ready, so it doesn't interfere with replication.

As such, we should add the ability to set an environment variable to skip the pre_deploy script entirely.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:pre-deploy-skip-env > mozilla:master

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/680249cdeb3d566bcd335b27e0b9a354ab2d9379
Bug 1270454 - Allow skipping the Heroku pre_deploy script entirely

...by defining 'SKIP_PREDEPLOY' in the environment.

This is useful in cases where we want to avoid potentially destructive
actions (such as running migrations) from taking place, or know that the
migration is just going to time out unless run by hand.

https://github.com/mozilla/treeherder/commit/bb60ca61503f738e77be43cda7f7960aec4083a3
Merge pull request #1460 from mozilla/pre-deploy-skip-env

Bug 1270454 - Allow skipping the Heroku pre_deploy script entirely