Tools Menu not dismissed when switching orientation on iPhones

VERIFIED FIXED

Status

()

Firefox for iOS
Menu and Toolbar
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: csuciu, Assigned: fluffyemily)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios-v5.0 verified, fxios5.0+)

Details

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review | Splinter Review
(Reporter)

Description

2 years ago
iPhone 6 Plus (9.3.1)
latest master

1. With the phone placed in landscape, open Tools Menu.
2. Rotate to portrait. 
3. Rotate to landscape.

Result:
When switching to portrait, the menu is briefly shown, then disappears. 
When switching back to landscape, the menu is open
(Reporter)

Updated

2 years ago
Blocks: 1210109
(Reporter)

Comment 1

2 years ago
This will also cause for the menu that is shown in browser view to be displayed in tabs tray or in the home screen:

1. Open menu in landscape
2. Rotate to portrait
3. Open tabs tray or go to the home screen  
4. Rotate to landscape
(Assignee)

Updated

2 years ago
tracking-fxios: ? → 5.0+
(Assignee)

Updated

2 years ago
Rank: 3
(Assignee)

Updated

2 years ago
Assignee: nobody → etoop
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Created attachment 8751371 [details] [review]
Pull request
Attachment #8751371 - Flags: review?(sleroux)
Comment on attachment 8751371 [details] [review]
Pull request

This is pretty hacky and gross but I can't think of another way of doing it :(
Attachment #8751371 - Flags: review?(sleroux) → review+
(Assignee)

Comment 4

2 years ago
(In reply to Stephan Leroux [:sleroux] from comment #3)
> Comment on attachment 8751371 [details] [review]
> Pull request
> 
> This is pretty hacky and gross but I can't think of another way of doing it
> :(

I know. If I could have found another way I would have done it. I hate writing code like this, but hacky code is better than bad User Experience I suppose.
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

2 years ago
Verifying as fixed on master e5b6720f
Status: RESOLVED → VERIFIED
status-fxios-v5.0: affected → verified
You need to log in before you can comment on or make changes to this bug.