1270456 - Tools Menu not dismissed when switching orientation on iPhones

Status: VERIFIED FIXED

Description

[Catalin Suciu [:csuciu]]

iPhone 6 Plus (9.3.1)
latest master

1. With the phone placed in landscape, open Tools Menu.
2. Rotate to portrait. 
3. Rotate to landscape.

Result:
When switching to portrait, the menu is briefly shown, then disappears. 
When switching back to landscape, the menu is open

Comment 1

[Catalin Suciu [:csuciu]]

This will also cause for the menu that is shown in browser view to be displayed in tabs tray or in the home screen:

1. Open menu in landscape
2. Rotate to portrait
3. Open tabs tray or go to the home screen  
4. Rotate to landscape

Comment 2

[Emily Toop (:fluffyemily)]

Created attachment 8751371 [details] [review]
Pull request

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8751371 [details] [review]
Pull request

This is pretty hacky and gross but I can't think of another way of doing it :(

Comment 4

[Emily Toop (:fluffyemily)]

(In reply to Stephan Leroux [:sleroux] from comment #3)
> Comment on attachment 8751371 [details] [review]
> Pull request
> 
> This is pretty hacky and gross but I can't think of another way of doing it
> :(

I know. If I could have found another way I would have done it. I hate writing code like this, but hacky code is better than bad User Experience I suppose.

Comment 5

[Catalin Suciu [:csuciu]]

Verifying as fixed on master e5b6720f