Toggling tracking protection in private browsing using the keyboard doesn't work reliably

VERIFIED FIXED in Firefox 48

Status

()

defect
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: arni2033, Assigned: Gijs)

Tracking

({access, regression})

48 Branch
Firefox 49
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox47 unaffected, firefox48+ verified, firefox49 verified)

Details

Attachments

(1 attachment)

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160504043118
STR:
1. Open private window (Ctrl+Shift+P)
2. Press Tab key several times to focus the slider (input[type="checkbox"] element)
3. Press Spacebar to toggle its state

AR:  The slider inside input changes its position, and that's all
ER:  Private browsing mode should change

Note:  I haven't checked regression range, but Release 45 is unaffected.
Hm, probably only Spacebar key allows this suspicious operation, while Enter key works fine.
In this case the summary should be altered (I currently can't check it on latest Nightly)
Keywords: access
Summary: It's impossible to toggle private browsing mode using keyboard (~a11y) → Toggling tracking protection in private browsing using the keyboard doesn't work reliably
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8749220 [details]
MozReview Request: Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws

https://reviewboard.mozilla.org/r/50811/#review47511

Please add a better commit message.
Attachment #8749220 - Flags: review?(jaws) → review+
Comment on attachment 8749220 [details]
MozReview Request: Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50811/diff/1-2/
Attachment #8749220 - Attachment description: MozReview Request: Bug 1270496 - fix tracking protection toggle, r?jaws → MozReview Request: Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws
https://hg.mozilla.org/mozilla-central/rev/519a07622021
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8749220 [details]
MozReview Request: Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws

Approval Request Comment
[Feature/regressing bug #]: bug 1259340
[User impact if declined]: toggling tracking protection with the keyboard on about:privatebrowsing *seems* to work, but doesn't. This is misleading and worrying.
[Describe test coverage new/current, TreeHerder]: nope :-(
[Risks and why]: low risk - this is a small JS-only patch, and manual testing is easy - you can open about:config in a separate tab and watch the prefs change and make sure that happens
[String/UUID change made/needed]: nope
Attachment #8749220 - Flags: approval-mozilla-aurora?
Tracking, recent regression from 48
Flags: qe-verify+
Comment on attachment 8749220 [details]
MozReview Request: Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws

Recent regression fix, please uplift.
Attachment #8749220 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed FX 48b1, 49.0a2 (2016-06-08) Win 7.
Status: RESOLVED → VERIFIED
Version: unspecified → 48 Branch
You need to log in before you can comment on or make changes to this bug.