Closed
Bug 1270496
Opened 8 years ago
Closed 8 years ago
Toggling tracking protection in private browsing using the keyboard doesn't work reliably
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
VERIFIED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | + | verified |
firefox49 | --- | verified |
People
(Reporter: arni2033, Assigned: Gijs)
References
Details
(Keywords: access, regression)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
jaws
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
>>> My Info: Win7_64, Nightly 49, 32bit, ID 20160504043118
STR:
1. Open private window (Ctrl+Shift+P)
2. Press Tab key several times to focus the slider (input[type="checkbox"] element)
3. Press Spacebar to toggle its state
AR: The slider inside input changes its position, and that's all
ER: Private browsing mode should change
Note: I haven't checked regression range, but Release 45 is unaffected.
Hm, probably only Spacebar key allows this suspicious operation, while Enter key works fine. In this case the summary should be altered (I currently can't check it on latest Nightly)
Assignee | ||
Updated•8 years ago
|
Keywords: access
Summary: It's impossible to toggle private browsing mode using keyboard (~a11y) → Toggling tracking protection in private browsing using the keyboard doesn't work reliably
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
status-firefox48:
--- → affected
status-firefox49:
--- → affected
tracking-firefox48:
--- → ?
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50811/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50811/
Attachment #8749220 -
Flags: review?(jaws)
Comment 3•8 years ago
|
||
Comment on attachment 8749220 [details] MozReview Request: Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws https://reviewboard.mozilla.org/r/50811/#review47511 Please add a better commit message.
Attachment #8749220 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8749220 [details] MozReview Request: Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50811/diff/1-2/
Attachment #8749220 -
Attachment description: MozReview Request: Bug 1270496 - fix tracking protection toggle, r?jaws → MozReview Request: Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/519a07622021
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8749220 [details] MozReview Request: Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws Approval Request Comment [Feature/regressing bug #]: bug 1259340 [User impact if declined]: toggling tracking protection with the keyboard on about:privatebrowsing *seems* to work, but doesn't. This is misleading and worrying. [Describe test coverage new/current, TreeHerder]: nope :-( [Risks and why]: low risk - this is a small JS-only patch, and manual testing is easy - you can open about:config in a separate tab and watch the prefs change and make sure that happens [String/UUID change made/needed]: nope
Attachment #8749220 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
Flags: qe-verify+
Comment 9•8 years ago
|
||
Comment on attachment 8749220 [details] MozReview Request: Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r?jaws Recent regression fix, please uplift.
Attachment #8749220 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/bfde37f7c542
Comment 11•8 years ago
|
||
Verified fixed FX 48b1, 49.0a2 (2016-06-08) Win 7.
Updated•8 years ago
|
status-firefox47:
--- → unaffected
Version: unspecified → 48 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•