1270518 - Make object.code reflect as string, not URL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

The spec says regular string:

"""
The align, archive, border, code, declare, hspace, standby, and vspace IDL attributes of the object element must reflect the respective content attributes of the same name.
"""
https://html.spec.whatwg.org/#dom-object-code

Chrome and IE 11 appear to reflect as a string.  I can't figure out what this attribute does or ever did, if anything -- I don't see any sort of documentation anywhere.  If it actually does something and is logically a URL, it would make sense to change the spec.  Otherwise, we should change.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: 0001-Bug-1270518-Make-object.code-reflect-as-string-not-U.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=99c44faccce0&exclusion_profile=false

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8749211 [details] [diff] [review]
0001-Bug-1270518-Make-object.code-reflect-as-string-not-U.patch

Yeah, I dunno why this is being reflected as URL.  It's https://www.w3.org/TR/1999/REC-html401-19991224/struct/objects.html#adef-code and corresponding bits from https://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-61509645 and https://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-75241146 which is a filepath, not a URL.

r=me.

I would somewhat appreciate you finding some other reviewers for these various changes, by the way.  ;)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7428c2afbc5c

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7428c2afbc5c