Closed Bug 1270522 Opened 8 years ago Closed 8 years ago

Crash in java.lang.NullPointerException: at org.mozilla.gecko.gfx.GeckoLayerClient.sendResizeEventIfNecessary(GeckoLayerClient.java)

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

47 Branch
Unspecified
Android
defect
Not set
critical

Tracking

(firefox47+ fixed, firefox48 fixed, firefox49 fixed, fennec47+)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox47 + fixed
firefox48 --- fixed
firefox49 --- fixed
fennec 47+ ---

People

(Reporter: kbrosnan, Assigned: snorp)

Details

(Keywords: crash, regression, topcrash-android-armv7)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-b6d19e05-734e-4b9d-bd7f-ea7c92160504.
=============================================================

java.lang.NullPointerException
	at org.mozilla.gecko.gfx.GeckoLayerClient.sendResizeEventIfNecessary(GeckoLayerClient.java:284)
	at org.mozilla.gecko.gfx.GeckoLayerClient.onGeckoReady(GeckoLayerClient.java:164)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:443)
Assignee: nobody → snorp
tracking-fennec: ? → 47+
James, is this something that worries you?  Let me know if you don't have time for it, or unassign, and I'll find somebody.
Flags: needinfo?(snorp)
This is currently the #8 crash in Fennec Beta accounting for 1.64% of the overall volume. It's also categorized as a startup crash since 63% of the reports happen within 1 minute of uptime. Strangely it appears as though these reports are isolated to the 47 branch which makes me think this issue could be under a different signature in other branches.
Attachment #8755437 - Flags: review?(rbarker) → review+
This looks like a good candidate for an uplift, nullptr check, and this regressed in 47, so we could catch up and not ship it at all.
Version: Trunk → 47 Branch
Thanks, Milan
Flags: needinfo?(snorp)
Comment on attachment 8755437 [details] [diff] [review]
Guard against a null view in GeckoLayerClient.sendResizeEventIfNecessary()

Approval Request Comment
[Feature/regressing bug #]: Unknown
[User impact if declined]: Crashes
[Describe test coverage new/current, TreeHerder]: nightly
[Risks and why]: low, only adds a null check
[String/UUID change made/needed]: none
Attachment #8755437 - Flags: approval-mozilla-beta?
Comment on attachment 8755437 [details] [diff] [review]
Guard against a null view in GeckoLayerClient.sendResizeEventIfNecessary()

Crash fix, there's ~200 crashes in a week on 47.0b6 and the fix is a simple not-null check, Aurora48+, Beta47+
Attachment #8755437 - Flags: approval-mozilla-beta?
Attachment #8755437 - Flags: approval-mozilla-beta+
Attachment #8755437 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/5abd0e13a583
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.