1270628 - Stop using content-child-shutdown observer

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This observer is only supposed to be used for things that need to send persistent data to the parent process before shutdown (e.g., telemetry or session store data). It shouldn't be used to remove observers or release memory, since we want to avoid doing those things in opt builds.

I'm going to remove some of these uses in this bug. The others will be handled in bug 1270308.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: webrtc patch

This one uses an xpcom-shutdown observer for WebRTC. That will cause us to remove the observers in DEBUG builds but do nothing in opt builds, which is what we want.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: nsPerformanceStats fix

This does the same thing for nsPerformanceStats. It already listens for xpcom-will-shutdown, so we can just remove the content-child-shutdown observer.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8749390 [details] [diff] [review]
nsPerformanceStats fix

Review of attachment 8749390 [details] [diff] [review]:
-----------------------------------------------------------------

If this doesn't cause memory leaks in DEBUG, I'm fine with that change.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9db24868efd

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d9db24868efd