Closed
Bug 1270670
Opened 8 years ago
Closed 8 years ago
Em dash separator in awesomebar popup has incorrect spacing/padding on Windows, Linux in RTL
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
Firefox 49
People
(Reporter: adw, Assigned: adw)
References
Details
(Keywords: regression)
Attachments
(2 files)
58 bytes,
text/x-review-board-request
|
mak
:
review+
|
Details |
1.42 KB,
patch
|
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•8 years ago
|
||
osx/global/autocomplete.css has the correct -moz-margin-start/end. I must have fixed that locally and then neglected to copy it to Windows and Linux. Review commit: https://reviewboard.mozilla.org/r/50965/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50965/
Attachment #8749462 -
Flags: review?(mak77)
Updated•8 years ago
|
Attachment #8749462 -
Flags: review?(mak77) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8749462 [details] MozReview Request: Bug 1270670 - Fix spacing around em dash separator in awesomebar popup on Windows, Linux in RTL. r?mak https://reviewboard.mozilla.org/r/50965/#review47645 this should be uplifted
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8000d7a6ff44
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Comment 5•8 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: New awesomebar popup design, bug 1181078 [User impact if declined]: Small incorrect visual styling for RTL users on Windows and Linux [Describe test coverage new/current, TreeHerder]: No new coverage needed [Risks and why]: Very low risk, style-only change that tweaks the margins around the separator em dash in awesomebar popup results [String/UUID change made/needed]: None
Attachment #8749895 -
Flags: approval-mozilla-aurora?
Comment 6•8 years ago
|
||
Confirming the fix for this issue on the AR build of 49.0a1, build ID: 20160508030214.
Status: RESOLVED → VERIFIED
Comment 7•8 years ago
|
||
Comment on attachment 8749895 [details] [diff] [review] Aurora 48 patch css only change, regression in 48. Please uplift to aurora.
Attachment #8749895 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/2e36dd3e9594
You need to log in
before you can comment on or make changes to this bug.
Description
•