1270690 - Interaction of footer and ship it checkbox is annoying

Status: RESOLVED INVALID

(MozReview Graveyard :: Review Board: Upstream, defect)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1) Click the Finish Review thing.
2) Click the "Add Footer" link.
3) Type something in the "Edit footer" textfield.  Do _not_ click "OK" there.
4) Click on the "Ship it" checkbox"

ACTUAL RESULTS: The stuff you typed disappears, the "Add Footer" link appears again.

EXPECTED RESULTS: Do not disappear my stuff.

NOTE: If you finish the review at this point, the stuff that was placed in the "Edit footer" textfield _will_ show up in your review comments.  So it just totally _looks_ like dataloss, but I'm not sure it actually is.

Comment 1

[Mark Côté [:mcote]]

Huh yeah, that's annoying.  An upstream bug, I imagine.  We'll look into it.

This does, however, raise an interesting point that we've been thinking about: do you actually find the footer useful?  Based on other user feedback, the presence of both a header and a footer is at best redundant and at worse confusing.  We were considering removing it and just renaming "header" to "general comments" or something similar.  Do you find the footer better than the header for some use cases?

I realize this is off-topic for this bug but figured I'd get your opinion before filing a "remove footer" bug.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I typically put my conclusion in the footer.  Either "r=me" or "r=me with the above fixed" or "r=me but I want to see your updated changes before you land" or "r-" or whatever the outcome of the whole thing is.

I find the header somewhat less useful; it's rare that I need to make a bunch of general comments on a patch that come before the line comments.  But does happen.

Comment 3

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.