Closed
Bug 1270693
Opened 8 years ago
Closed 8 years ago
FindInPageBar Keyboard Improvements
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 5.0+ | --- |
People
(Reporter: st3fan, Assigned: st3fan)
Details
Attachments
(1 file)
|
48 bytes,
text/x-github-pull-request
|
bnicholson
:
review+
tecgirl
:
ui-review+
tecgirl
:
feedback+
|
Details | Review |
On iPad with a hardware keyboard, I think it would be nice to do two things similar to Safari: * Hide the shortcuts bar above the keyboard (both with virtual and hardware kbd) * Go to the next search result when the user hits the enter key (only with hardware kbd)
|
Assignee | |
Updated•8 years ago
|
Summary: Improve keyboard support in the FindInPageBar → FindInPageBar Keyboard Improvements
|
|
Assignee | |
Comment 1•8 years ago
|
||
This patch does three things: * Remove the shortcuts bar for less clutter and safari parity. See screenshots below. This only affects iPad and iOS9. * Enable `enablesReturnKeyAutomatically` so that the return key stays disabled unless there is content in the field * Change the *return* key to be *Search* instead
Attachment #8749622 -
Flags: ui-review?(randersen)
Attachment #8749622 -
Flags: review?(bnicholson)
|
|
Assignee | |
Updated•8 years ago
|
tracking-fxios:
--- → 5.0+
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8749622 [details] [review] PR: https://github.com/mozilla/firefox-ios/pull/1782 Looks better!
Attachment #8749622 -
Flags: review?(bnicholson) → review+
|
|
||
Updated•8 years ago
|
Assignee: nobody → sarentz
Status: NEW → ASSIGNED
|
||
Updated•8 years ago
|
Attachment #8749622 -
Flags: ui-review?(randersen)
Attachment #8749622 -
Flags: ui-review+
Attachment #8749622 -
Flags: feedback+
|
|
Assignee | |
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•