1270710 - [TV][Home] Navigate to folder, cards in folder will be shown but overlap folder's name

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)

Description

[Mike Lien[:mlien]]

Attachment: Card overlaps folder's name

[Testing Steps]
1. Add a new folder with any card
2. Navigate to step 1's folder

[Expected result]
Folder's name shouldn't be overlapped

[Actual result]
Cards in folder will be shown but overlap folder's name

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/18fc4607ca127805586803e9300927ae257f725a
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/ccf59a9dda868db58b5d943e2c4235ead89f9344

Comment 1

[Luke Chang [:lchang] (inactive)]

Hi Peko,

According to item 1.3 in Visual Spec ( https://goo.gl/lgxwxU ), I suppose it is by design. Could you help to confirm that? Thanks.

Comment 2

[Fischer [:Fischer]]

According to the discussion with UX, the updated behavior is:
- Hide the main cards' names when folder is opened
- Show the main cards' names when folder is closed

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1270710-card-names-overlap-when-folder-opened > mozilla-b2g:v2.6

Comment 4

[Fischer [:Fischer]]

Comment on attachment 8753233 [details] [review]
[gaia] Fischer-L:bug_1270710-card-names-overlap-when-folder-opened > mozilla-b2g:v2.6

@Luke,
This patch 
- Hide the main cards' names when folder is opened
- Show the main cards' names when folder is closed
Thanks

Comment 5

[Fischer [:Fischer]]

Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/fab08a4cd9125255c86148ace711a018ede9e540

Comment 6

[Mike Lien[:mlien]]

verified and fixed with the latest build
2.6 simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/6453008b2383b530d771b8c6abc0526298f2a7c5
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/425aaa9763aef80ec1f7e78079e410ee1ccc9e32