1270757 - [TV][Browser] Browser UI polish

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect)

Description

[Dan Huang[:danhuang]]

Browser UI polish according to visual spec.

Comment 1

[Dan Huang[:danhuang]]

Attachment: Landing page

Please help ui-review the screen shot. This screen shot is taken from the browser landing page. Thanks.

Comment 2

[Dan Huang[:danhuang]]

Attachment: Landing page with sidebar expand

Please help ui-review the screen shot. This screen shot is taken from the browser landing page with sidebar expand. Thanks.

Comment 3

[Peko Chen [:pekochen]]

Comment on attachment 8754707 [details]
Landing page

Hi Dan,

Please see the attached file for your reference.
Thanks for your great help.

Comment 4

[Peko Chen [:pekochen]]

Attachment: UI REVIEW_01.png

Comment 5

[Peko Chen [:pekochen]]

Attachment: UI REVIEW_02.png

Review for Sidebar expand.

Comment 6

[Dan Huang[:danhuang]]

Attachment: Landing page

Please help ui-review again. This screen shot is taken from the browser landing page and update according to the attachment 8756676 [details]. Thanks.

Comment 7

[Dan Huang[:danhuang]]

Attachment: Landing page with sidebar expand

Please help ui-review again. This screen shot is taken from the browser landing page with sidebar expand and update the style according to the attachment 8756681 [details]. Thanks.

Comment 8

[Dan Huang[:danhuang]]

Attachment: Landing page

Updated: align icon the center

Comment 9

[Dan Huang[:danhuang]]

Attachment: Landing page with sidebar expand

Updated: align icon the center

Comment 10

[Peko Chen [:pekochen]]

Comment on attachment 8757191 [details]
Landing page

Thanks for your help!
GJ

Comment 11

[Peko Chen [:pekochen]]

Comment on attachment 8757193 [details]
Landing page with sidebar expand

Thanks for your help!
GJ

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1270757_browser_ui_polich > mozilla-b2g:master

Comment 13

[Dan Huang[:danhuang]]

Comment on attachment 8757987 [details] [review]
[gaia] danhuang1202:1270757_browser_ui_polich > mozilla-b2g:master

Please help review this patch. This patch contains two parts. The first part is updating the style of toolbar panel[1]. And the second is updating the style of spatial navigation[2]. Thanks.

[1]https://drive.google.com/a/mozilla.com/file/d/0B4K8q1qWmtAvdkVWc1otdVN4Y0U/view
[2]https://drive.google.com/a/mozilla.com/file/d/0B4K8q1qWmtAvNTJZM1pJZjZHa1E/view

Comment 14

[Teri Wen [:twen]]

Hi Dan,

Please uplift to v2.6 branch.

Comment 15

[Teri Wen [:twen]]

once it is reviewed :)

Comment 16

[yifan [:yifan][:yliao]]

Comment on attachment 8757987 [details] [review]
[gaia] danhuang1202:1270757_browser_ui_polich > mozilla-b2g:master

Please fix the errors we discussed offline.

Comment 17

[Dan Huang[:danhuang]]

Comment on attachment 8757987 [details] [review]
[gaia] danhuang1202:1270757_browser_ui_polich > mozilla-b2g:master

Please help review again. This patch adds couple commits for fixing the following issues:
1. url input hover style not correct
2. menu list become active after clicking
3. keyboard didn't show when mouse hover in input field
4. toolbar layout not correct in private mode
5. toolbar layout not correct when forward shows
6. element focus style didn't disappear when spatial navigation disable

Comment 18

[yifan [:yifan][:yliao]]

Comment on attachment 8757987 [details] [review]
[gaia] danhuang1202:1270757_browser_ui_polich > mozilla-b2g:master

These issues can be resolve later if you'd like.

1. At the top sites page use arrow key to press the back button and bring up the exit browser dialog. After cancelling spatial navigation is disabled.

2. Focus style on some icons are not cleared after blur.

3. Reload button doesn't work.

4. At tab list, click out side of the list cannot close it.

5. When the search bar clicked: TypeError: disp.text.replace is not a function at tooltip.js:163

Also please try the patch on TV as well.

Comment 19

[Dan Huang[:danhuang]]

Thanks for the review. I would fire the follow up bug for those issues you mentioned.

Comment 20

[Dan Huang[:danhuang]]

Comment on attachment 8757987 [details] [review]
[gaia] danhuang1202:1270757_browser_ui_polich > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):TV 2.6
[User impact] if declined: not align to visual spec
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: Yes

Comment 21

[Josh Cheng [:josh]]

Comment on attachment 8757987 [details] [review]
[gaia] danhuang1202:1270757_browser_ui_polich > mozilla-b2g:master

Approve for TV 2.5

Comment 22

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:2.6_1270757 > mozilla-b2g:v2.6

Comment 23

[Dan Huang[:danhuang]]

Merge in v2.6:
https://github.com/mozilla-b2g/gaia/commit/099d4b0b13f1cc999fd5bb8b66178c53982ee5dc