1270774 - Intermittent test_memory_footprint.js | xpcshell return code: 0 followed by connect_client - [connect_client : 26] Footprint after DebuggerClient.connect() is

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Carsten Book [:Tomcat]]

TEST-UNEXPECTED-FAIL | devtools/server/tests/unit/test_memory_footprint.js | xpcshell return code: 0

 01:47:07 WARNING - TEST-UNEXPECTED-FAIL | devtools/server/tests/unit/test_memory_footprint.js | connect_client - [connect_client : 26] Footprint after DebuggerClient.connect() is 2608 kB (should be less than 2600 kB).

https://treeherder.mozilla.org/logviewer.html#?job_id=27364462&repo=mozilla-inbound#L7285

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:terrence, it seems limits changed in bug 1267812 were not high enough for all cases.  Should we raise them a bit more?

Comment 2

[Terrence Cole [:terrence]]

Yes, I believe we should. I think the issue is that we're not actually evacuating the nursery before testing the heap size, so up to 16MiB of in-use memory is getting blackholed by these measurements. Since I made the nursery GC more frequent for chrome code, we're probably seeing memory that was there before, but was getting ignored. I'll bump these up another 400KiB so that they are a round 1MiB above where they were before.

Comment 3

[Terrence Cole [:terrence]]

Attachment: fix_devtools_memory_limits-v0.diff

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8749739 [details] [diff] [review]
fix_devtools_memory_limits-v0.diff

Review of attachment 8749739 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d6d5ca13d3d0bf0398537a2336c4728736a92e6
Bug 1270774 - Fix devtool memory test limits to allow for more nursery slop; r=fitzgen

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5d6d5ca13d3d