Closed Bug 1270811 Opened 4 years ago Closed 4 years ago

[Static Analysis][Uninitialized pointer field] In function GraphStoreInfo::GraphStoreInfo

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1358980)

Attachments

(1 file)

The Static Analysis tool Coverity added that variable |current_| is not initialized in constructor. As we would like to adopt a more RAII and to get the code ready to integrate this clang-plugin: https://bugzilla.mozilla.org/show_bug.cgi?id=525063 we should initialized the pointer will nullptr.
Attachment #8749619 - Flags: review?(jdemooij)
Attachment #8749619 - Flags: review?(jdemooij) → review?(hv1989)
Attachment #8749619 - Flags: review?(hv1989) → review+
Comment on attachment 8749619 [details]
MozReview Request: Bug 1270811 - initialize |current_| in GraphStoreInfo. r?jdemooij

https://reviewboard.mozilla.org/r/51069/#review48327

Definitely!
https://hg.mozilla.org/mozilla-central/rev/7bab57b555e0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.