1270811 - [Static Analysis][Uninitialized pointer field] In function GraphStoreInfo::GraphStoreInfo

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that variable |current_| is not initialized in constructor. As we would like to adopt a more RAII and to get the code ready to integrate this clang-plugin: https://bugzilla.mozilla.org/show_bug.cgi?id=525063 we should initialized the pointer will nullptr.

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1270811 - initialize |current_| in GraphStoreInfo. r?jdemooij

Review commit: https://reviewboard.mozilla.org/r/51069/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51069/

Comment 2

[Hannes Verschore [:h4writer]]

Comment on attachment 8749619 [details]
MozReview Request: Bug 1270811 - initialize |current_| in GraphStoreInfo. r?jdemooij

https://reviewboard.mozilla.org/r/51069/#review48327

Definitely!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7bab57b555e0

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7bab57b555e0