[Static Analysis][Uninitialized pointer field] In function GraphStoreInfo::GraphStoreInfo

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla49
coverity
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: CID 1358980)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The Static Analysis tool Coverity added that variable |current_| is not initialized in constructor. As we would like to adopt a more RAII and to get the code ready to integrate this clang-plugin: https://bugzilla.mozilla.org/show_bug.cgi?id=525063 we should initialized the pointer will nullptr.
(Assignee)

Comment 1

2 years ago
Created attachment 8749619 [details]
MozReview Request: Bug 1270811 - initialize |current_| in GraphStoreInfo. r?jdemooij

Review commit: https://reviewboard.mozilla.org/r/51069/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51069/
(Assignee)

Updated

2 years ago
Attachment #8749619 - Flags: review?(jdemooij)

Updated

2 years ago
Attachment #8749619 - Flags: review?(jdemooij) → review?(hv1989)
Attachment #8749619 - Flags: review?(hv1989) → review+
Comment on attachment 8749619 [details]
MozReview Request: Bug 1270811 - initialize |current_| in GraphStoreInfo. r?jdemooij

https://reviewboard.mozilla.org/r/51069/#review48327

Definitely!

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7bab57b555e0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.