1270814 - [Static Analysis][Uninitialized pointer field] In function constructor LoopUnroller::LoopUnroller

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that the pointers from class LoopUnroller are not initialized.  As we would like to adopt a more RAII and to get the code ready to integrate this clang-plugin: https://bugzilla.mozilla.org/show_bug.cgi?id=525063 we should initialized the pointers will nullptr.

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1270814 - initialize pointers from LoopUnroller. r?jdemooij

Review commit: https://reviewboard.mozilla.org/r/51073/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51073/

Comment 2

[Andi [:andi]]

Comment on attachment 8749623 [details]
MozReview Request: Bug 1270814 - initialize pointers from LoopUnroller. r?jdemooij

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51073/diff/1-2/

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8749623 [details]
MozReview Request: Bug 1270814 - initialize pointers from LoopUnroller. r?jdemooij

https://reviewboard.mozilla.org/r/51073/#review48319

Thanks.

::: js/src/jit/LoopUnroller.cpp:25
(Diff revision 2)
>      typedef HashMap<MDefinition*, MDefinition*,
>                      PointerHasher<MDefinition*, 2>, SystemAllocPolicy> DefinitionMap;
>  
>      explicit LoopUnroller(MIRGraph& graph)
> -      : graph(graph), alloc(graph.alloc())
> +      : graph(graph), alloc(graph.alloc()),
> +        header(nullptr), backedge(nullptr), 

Nit: remove trailing whitespace on this line

Comment 4

[Andi [:andi]]

Comment on attachment 8749623 [details]
MozReview Request: Bug 1270814 - initialize pointers from LoopUnroller. r?jdemooij

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51073/diff/2-3/

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cbb01e669859

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cbb01e669859