1270842 - Unable to remove a bookmark from Timeline->Bookmarks tab

Status: VERIFIED FIXED

(Firefox Graveyard :: Activity Streams: Timeline, defect)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: RemoveBookmarks.mp4

[Affected versions]:
- Firefox 45.0 and up
- Activity Stream 1.0.15-dev

[Affected Platforms]:
- All Windows
- All Mac OS X
- All Linux

[Prerequisites]:
- Latest Activity Stream add-on version (1.0.15-dev) was previously installed on a clean profile.  

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites. 
2. Open Activity Stream from the browser toolbar and click the on the Bookmarks tab.
3. Hover one of the saved bookmarks and click the "X" button.

[Expected result]:
The option to remove a bookmark from Bookmarks should be available in the context menu.

[Actual result]:
Instead of having an option to remove a bookmark from Bookmarks, we only have the option to remove from History.

[Notes]:
- If you remove a bookmark from History, it is removed from the page, but after a refresh it reappears.
- From the User's perspective the option to remove from History doesn't make much sense in the Bookmarks tab since this can be achieved from Timeline->All History page. 
- Attached a screen recording of the issue.

Comment 1

[Paul Oiegas [:poiegas], PM for (Ecosystem QA, Services QA, WebCompat QA, Ads QA, and Solo QA teams)]

Filed in Github as https://github.com/mozilla/activity-streams/issues/659

Comment 2

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

This issue is fixed by https://github.com/mozilla/activity-stream/pull/715.

Comment 3

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have tested this issue on Windows 10 x64, Windows 7 x64, Mac OS 10.11 and Ubuntu 15.10 x64 with the latest Nightly (49.0a1, Build ID 20160525063710) using the latest version of the Activity Stream add-on (v1.0.18-dev) and the issue is no longer reproducible.