Closed Bug 1270943 Opened 4 years ago Closed 4 years ago

Bug 1154277 didn't re-enable the chat tests on e10s

Categories

(Hello (Loop) :: Client, defect)

Unspecified
All
defect
Not set

Tracking

(e10s+, firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
e10s + ---
firefox49 --- fixed

People

(Reporter: RyanVM, Assigned: mikedeboer)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

AFAICT, the intent in bug 1154277 was to get the tests in browser/base/content/test/chat cleaned up and suitable for running in e10s mode. But it appears that the global |skip-if = e10s| at the top of the manifest was never removed and we've been skipping them all this time.

I'll fire off a Try push to see where things stand. Hopefully nothing's regressed them in the last 3 months.
Looks like browser_focus.js is failing now.
https://treeherder.mozilla.org/logviewer.html#?job_id=20488166&repo=try
Flags: needinfo?(mdeboer)
Woa, I never noticed the global disable instruction! I'll fix this.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(mdeboer)
Attachment #8750292 - Attachment is obsolete: true
Attachment #8750292 - Flags: review?(mixedpuppy)
Attachment #8750339 - Flags: review?(mixedpuppy)
Comment on attachment 8750339 [details] [diff] [review]
Patch v2: fix e10s issues in browser_focus.js mochitest and enable all chat tests


>@@ -28,19 +28,23 @@ var chatbar = document.getElementById("p

>-  tab.linkedBrowser.contentDocument.getElementById("theinput").focus();
>+  let tab = gBrowser.selectedTab = gBrowser.addTab(url, { skipAnimation: true });
>+  let browser = tab.linkedBrowser;
>+  yield promiseOneEvent(browser, "load", true);

The above can be done with

let tab = yield BrowserTestUtils.openNewForegroundTab(gBrowser, url);
let browser = tab.linkedBrowser;

>+  yield ContentTask.spawn(browser, null, function* () {
>+    content.document.getElementById("theinput").focus();
>+  });
>+
Attachment #8750339 - Flags: review?(mixedpuppy) → review+
https://hg.mozilla.org/integration/fx-team/rev/8cf323be5c58b28d8719401ebb0ef63f1d71d000
Bug 1270943 - fix e10s issues in browser_focus.js mochitest and enable all chat tests, for sure this time. r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/8cf323be5c58
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.