1270958 - Include string for "1 device" instead of "1 devices" for Synced devices

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1270958 - Include string for "1 device" instead of "1 devices" for Synced devices. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/51173/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51173/

Comment 2

[Chenxia Liu [:liuche]]

Delphine, I realized while reviewing bug 1269001 that I also need a "single item" string like the one mentioned in that bug, so I added it here. I'm going to flag it for aurora uplift, because this should have been part of bug 1261527, but I forgot about that case - sorry about that! I'm hoping that if it's similar to the case with both of those bugs that this string will be all right.

Comment 3

[Andrzej Hunt :ahunt]

Comment on attachment 8749824 [details]
MozReview Request: Bug 1270958 - Include string for "1 device" instead of "1 devices" for Synced devices. r=ahunt

https://reviewboard.mozilla.org/r/51173/#review47869

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b7240a704aeb

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 8749824 [details]
MozReview Request: Bug 1270958 - Include string for "1 device" instead of "1 devices" for Synced devices. r=ahunt

Approval Request Comment
[Feature/regressing bug #]: Missed "single item" state from bug 1261527
[User impact if declined]: single device will show up as "1 devices"
[Describe test coverage new/current, TreeHerder]: local
[Risks and why]: very low, adds a string and simple logic
[String/UUID change made/needed]: Approval given in bug 1261527, and almost exact case as bug 1269001 - https://bugzilla.mozilla.org/show_bug.cgi?id=1269001#c10

Comment 6

[Delphine Lebédel [:delphine - Use needinfo]]

Thanks :liuche. Let's just get that landed asap. thanks!

Comment 7

[Stefan Plewako [:stef]]

Please include proper localization,
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_and_Plurals

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b7240a704aeb

Comment 9

[:Margaret Leibovic]

(In reply to Stefan Plewako [:stef] from comment #7)
> Please include proper localization,
> https://developer.mozilla.org/en-US/docs/Mozilla/Localization/
> Localization_and_Plurals

Yes, I was just about to link to this.

Do we have a way to properly support plural forms with Android strings? Not all languages have only one plural form. We have logic to handle this in Gecko, but I would think Android also has something.

Let's address that before uplifting.

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to :Margaret Leibovic from comment #9)
> (In reply to Stefan Plewako [:stef] from comment #7)
> > Please include proper localization,
> > https://developer.mozilla.org/en-US/docs/Mozilla/Localization/
> > Localization_and_Plurals
> 
> Yes, I was just about to link to this.
> 
> Do we have a way to properly support plural forms with Android strings? Not
> all languages have only one plural form. We have logic to handle this in
> Gecko, but I would think Android also has something.
> 
> Let's address that before uplifting.

I just saw this bug in my bugmail and wanted to post this URL too :) - after being fooled by that too recently (bug 1260390).

Android does have something[1] but that's not something we can support with our current approach using strings.xml.in.

[1] http://developer.android.com/guide/topics/resources/string-resource.html#Plurals

Comment 11

[Francesco Lodolo [:flod]]

(In reply to :Margaret Leibovic from comment #9)
> Do we have a way to properly support plural forms with Android strings? Not
> all languages have only one plural form. We have logic to handle this in
> Gecko, but I would think Android also has something.

We don't have anything, and that's something that I'd really like to be fixed, but it's far beyond the scope of this bug. If you search for "plural" in the file, you will find other old instances where we would a proper plural form.

Comment 12

[Chenxia Liu [:liuche]]

Margaret, since we can't do plural localization within Android's framework, do you think there is more that I should do for this bug? I could update the dtd entity name to clarify singular and plural, but the Android localization and l10n localization don't seem compatible right now.

Comment 13

[:Margaret Leibovic]

(In reply to Chenxia Liu [:liuche] from comment #12)
> Margaret, since we can't do plural localization within Android's framework,
> do you think there is more that I should do for this bug? I could update the
> dtd entity name to clarify singular and plural, but the Android localization
> and l10n localization don't seem compatible right now.

Given that this seems to be a pre-existing problem, I would just follow our current convention, e.g.:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-US/android_strings.dtd#100

Let's file a separate bug to try to come up with a real fix for this, which we can use for the existing plural form strings in the tree.

Comment 14

[Chenxia Liu [:liuche]]

Comment on attachment 8749824 [details]
MozReview Request: Bug 1270958 - Include string for "1 device" instead of "1 devices" for Synced devices. r=ahunt

Clearing a? flag because this probably too late for string uplift. This can just ride the trains.

Comment 15

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot from 2016-05-13 11:06:25.png

Tested using:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 49.0a1 (2016-05-12)