1270967 - Remove duplicate for gfxPrefs preferences from all.js

Status: NEW

(Core :: Graphics, task, P3)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Once we add a gfxPrefs, we have to decide if we want it to show up in about:support by default - if we do, we also need to add an entry in all.js.

Fix this so that we don't have to, and we can specify when defining the preference in gfxPrefs if we want also it to show up in the UI.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: WIP: Part 1. Preference interface for setting the defaults

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: WIP: Part 2. Extension to gfxPrefs to set the preference cache value

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: WIP: Part 3. Example changes to gfxPrefs and .js files

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8749864 [details] [diff] [review]
WIP: Part 2. Extension to gfxPrefs to set the preference cache value

Review of attachment 8749864 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPrefs.cpp
@@ +55,5 @@
>  {
>    gfxPrefs::AssertMainThread();
>    mMoz2DPrefAccess = new PreferenceAccessImpl;
>    mozilla::gfx::PreferenceAccess::SetAccess(mMoz2DPrefAccess);
> +  sIsParentProcess = XRE_IsParentProcess();

It is too late at this point to set the "is it a parent process" flag.  The member variable initialization has already tried to use that value.

Comment 5

[Andrey Bienkowski]

https://bugzilla.mozilla.org/show_bug.cgi?id=1548706