1270998 - Intermittent browser_aboutURLs.js | This test exceeded the timeout threshold. It should be rewritten or split up.

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=9202464&repo=fx-team

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Hi Jonas
I've found out the top 5 of the URLs that will take up most of the time,
they are
"about:addons", "about:healthreport", "about:debugging", "about:downloads", and "about:support".

However even I tried to remove them and re-run the tests, the tests still have some *intermittent* timeouts, so in the end I just increased the timeout.

Since you review the original test in Bug 1266022, can you review this test again?

Thanks

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8750174 [details] [diff] [review]
Patch.

Review of attachment 8750174 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know enough about this code to review. I suggest asking someone that's working on the contextual identity feature.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8750174 [details] [diff] [review]
Patch.

Review of attachment 8750174 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, Tanvi
Please see the explanation from Comment 1.

Thanks

Comment 4

[Intermittent Failures Robot]

11 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 7
* fx-team: 2
* try: 1
* mozilla-central: 1

Platform breakdown:
* linux64: 8
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1270998&startday=2016-05-10&endday=2016-05-16&tree=all

Comment 5

[Tanvi Vyas[:tanvi]]

Is this test just loading about: urls to ensure that they don't hit a crash?  What usercontextId are the about: pages loaded in?

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Tanvi Vyas - behind on reviews [:tanvi] from comment #5)
> Is this test just loading about: urls to ensure that they don't hit a crash?
yes

> What usercontextId are the about: pages loaded in?
https://dxr.mozilla.org/mozilla-central/source/browser/components/contextualidentity/test/browser/browser_aboutURLs.js#35

{userContextId: 1}

Comment 7

[Andrea Marchesini [:baku]]

Comment on attachment 8750174 [details] [diff] [review]
Patch.

Review of attachment 8750174 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/contextualidentity/test/browser/browser_aboutURLs.js
@@ +1,5 @@
> +"use strict";
> +
> +// For some about: URLs, they will take more time to load and cause timeout.
> +// See Bug 1270998.
> +requestLongerTimeout(2);

Seems good to me. Wondering why some about URLs are so slow.

Comment 8

[Intermittent Failures Robot]

13 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 9
* fx-team: 3
* try: 1

Platform breakdown:
* linux64: 8
* linux32: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1270998&startday=2016-05-16&endday=2016-05-22&tree=all

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Andrea Marchesini (:baku) from comment #7)
> Seems good to me. Wondering why some about URLs are so slow.
Thanks for the review, I'm also surprised that those URLs will take that long time, unfortunally I don't have enough time to check this now, will do some investigation after work week.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e65f2d5332c

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e65f2d5332c

Comment 12

[Intermittent Failures Robot]

6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* fx-team: 3
* try: 1
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* linux64: 5
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1270998&startday=2016-05-23&endday=2016-05-29&tree=all