1271042 - Error: SyntaxError: expected expression, got ',' in advanced.js

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Richard Marti (:Paenglab)]

Error: SyntaxError: expected expression, got ','
Source file: chrome://messenger/content/preferences/advanced.js
Line: 269, Column: 3
Source code:
  },

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1271042.patch

I missed the closing bracket in bug 1268154.

I think the indentations in this file aren't correct (the part after #ifdef MOZ_UPDATER). Aceman, what do you think, should I file a bug to correct the indentations?

Comment 2

[:aceman]

Comment on attachment 8749977 [details] [diff] [review]
1271042.patch

Review of attachment 8749977 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Yes, I think bugs about pure indentation/other cleanup changes have been accepted so far.

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/688ac84fd2c0ce9bf3ef781ee46e4c971a264db5
Bug 1271042 - Fix the missing bracket in advanced.js. r=aceman

Comment 5

[DELOUYA]

only source level fix provided (no such path/file ".../mail/components/preferences/advanced.js" in my install.. 
when will be available a version or applicable patch that actually unlock the Config Editor?

Comment 6

[:aceman]

(In reply to DELOUYA from comment #5)
> only source level fix provided (no such path/file
> ".../mail/components/preferences/advanced.js" in my install.. 
> when will be available a version or applicable patch that actually unlock
> the Config Editor?

The TB49 version (nightly) should contain it. Do you mean some specific branch like TB45.x?

Paenglab, do you know when this regressed?

Comment 7

[DELOUYA]

I just need a date. last release is dated May 8..
I want to raise another issue with unread mails deleted at second imap server poll - NOT A MINOR ISSUE!!
But I would like to rollback a config tunable to check if it is involved..
Locked..

Comment 8

[Richard Marti (:Paenglab)]

This patch landed on 2016-05-08. So every version from 9. and later should have this fix (my Daily 32bit is working). It seems the 64bit daily are broken since then.

(In reply to DELOUYA from comment #5)
> only source level fix provided (no such path/file
> ".../mail/components/preferences/advanced.js" in my install.. 
> when will be available a version or applicable patch that actually unlock
> the Config Editor?

This file is in the omni.ja (which is a secial packed zip file). You could extract the archive, patch the file and then repack it and rename it again to omni.ja.

But it would be better you use the 32bit version until there are again working 64bit versions.

Comment 9

[DELOUYA]

I am ready to apply the patch by hand. 
Which tools to extract and repack? (note that I am on  a Windows server - should I go thru a Linux machine tp proceed with the patch?)

Comment 10

[:aceman]

The omni.ja file is a zip archive.

Comment 11

[:aceman]

(In reply to :aceman from comment #6)
> Paenglab, do you know when this regressed?
Caused by bug 1268154, which landed in TB49 so no backport needed.

Comment 12

[Richard Marti (:Paenglab)]

7-Zip should work, or also WinRar. Important is, you don't edit the file in omni.ja because Mozilla uses some special optimization and this would break the ja file. Important on repacking is you don't change the directories structure.

Comment 13

[DELOUYA]

Config Editor is back! welcome to him..
FYI, 7-zip did not work it out (32/64b issue? endians? whatever?)
Going to a linux box, I could quickly apply the fix using zip/unzip..
The point is that the file shrank from 44Mb to 15Mb (???)
Stressing, but it works.. good to know?
I will now roll back on my config and see if it caused my main trouble!
(if every body switch to 32 bits, 64 bits guys won't make any progress ! -)
Thanks for your quick help

Comment 14

[:aceman]

(In reply to DELOUYA from comment #13)
> Config Editor is back! welcome to him..
> FYI, 7-zip did not work it out (32/64b issue? endians? whatever?)
> Going to a linux box, I could quickly apply the fix using zip/unzip..
> The point is that the file shrank from 44Mb to 15Mb (???)

Yes, it seems the shipped omni.ja is a zip archive, but compression is disabled. So if you zipped it back with default settings of zip, maybe it applied some compression. Anyway, if it works for you great (maybe a bit slower now due to needed decompression). If it chokes, you can try rezipping with compression disabled (must be an argument to zip).

Comment 15

[DELOUYA]

I catch!
The other good news is that, as I suspected, by roll backing a config tunable, 
the unread mail deletion issue disappeared!
I open a new bug! that killer must be solved!!
Thanks again..